Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8329109: Threads::print_on() tries to print CPU time for terminated GC threads #18518

Closed
wants to merge 3 commits into from
+1 −4
Closed

8329109: Threads::print_on() tries to print CPU time for terminated GC threads #18518

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
568a2bc
Fix
reinrich Mar 27, 2024
93e79dd
Revert
reinrich Apr 2, 2024
b2dabc9
Equivalent but simpler fix
reinrich Apr 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions src/hotspot/share/runtime/threads.cpp
View file
Original file line number Diff line number Diff line change
@@ -1336,10 +1336,7 @@ void Threads::print_on(outputStream* st, bool print_stacks,
}

PrintOnClosure cl(st);
cl.do_thread(VMThread::vm_thread());
Universe::heap()->gc_threads_do(&cl);
cl.do_thread(WatcherThread::watcher_thread());
cl.do_thread(AsyncLogWriter::instance());
non_java_threads_do(&cl);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This certainly looks neater and simpler and ensures all NJT's will be processed. There is additional synchronization involved in using the NonJavaThreads::Iterator that I had to look closely at but I think it is safe to use in this context.


st->flush();
}