Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8331134: Port SimpleStringBuilderStrategy to use ClassFile API #18690

Closed
wants to merge 12 commits into from
Closed

8331134: Port SimpleStringBuilderStrategy to use ClassFile API #18690

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
7c52a9f
Lower compilation overhead for large concat expressions, initial ASM-…
cl4es Apr 8, 2024
d99b159
Port ASM to CFA
cl4es Apr 9, 2024
b592899
Bump threshold after experiments
cl4es Apr 9, 2024
1c3d354
@liach feedback
cl4es Apr 12, 2024
796d968
Pre-size stringbuilders based on constant size and a small argument f…
cl4es Apr 14, 2024
9eed660
Dump using the hidden class name
cl4es Apr 15, 2024
fd9c40d
Merge master, resolve conflicts due pr/18688
cl4es Apr 18, 2024
83f4048
Minor SimpleStringBuilderStrategy::<clinit> overhead reduction
cl4es Apr 18, 2024
e7cbaaf
Update src/java.base/share/classes/java/lang/invoke/StringConcatFacto…
cl4es Apr 24, 2024
9742f07
Make Set.of(STRONG) a constant, fix compilation, minor code improvements
cl4es Apr 24, 2024
0ac8f24
Nits, clean up constant, introduce missing constant MethodTypeDesc fo…
cl4es Apr 24, 2024
f87fa1d
Rebase after integration of #18953
cl4es Apr 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/java.base/share/classes/java/lang/invoke/StringConcatFactory.java
View file
Original file line number Diff line number Diff line change
@@ -1101,11 +1101,10 @@ public void accept(ClassBuilder clb) {
}});

try {
Lookup hiddenLookup = lookup.defineHiddenClass(classBytes, true, STRONG);
Lookup hiddenLookup = lookup.makeHiddenClassDefiner(className, classBytes, Set.of(STRONG), DUMPER)
.defineClassAsLookup(true);
Class<?> innerClass = hiddenLookup.lookupClass();
DUMPER.dumpClass(innerClass.getName(), innerClass, classBytes);
MethodHandle mh = hiddenLookup.findStatic(innerClass, METHOD_NAME, args);
return mh;
return hiddenLookup.findStatic(innerClass, METHOD_NAME, args);
} catch (Exception e) {
DUMPER.dumpFailedClass(className, classBytes);
throw new StringConcatException("Exception while spinning the class", e);