Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8332497: javac prints an AssertionError when annotation processing runs on program with module imports #19292

Closed
wants to merge 24 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
9c7796a
Add visitModuleImport override to com.sun.tools.javac.tree.TreeScanner
Evemose May 19, 2024
08bce56
added testcase
Evemose May 19, 2024
f15c446
remove ^M chars in test
Evemose May 19, 2024
c6defcc
Added getSupportedSourceVersion() to AP
Evemose May 20, 2024
7b554e0
Added --enable-preview param
Evemose May 20, 2024
b642af2
Added --source param and moved annotation into Main class
Evemose May 20, 2024
a38583a
Added legal header and renamed test
Evemose May 21, 2024
a129ec0
Converted test to extend JavacTestingAbstractProcessor
Evemose May 22, 2024
c066d84
Added --enable-preview flag
Evemose May 22, 2024
1a07801
Replaced --release with @enablePreview
Evemose May 22, 2024
c629300
Removed artifact test
Evemose May 22, 2024
7bc8b3e
Removed ^M
Evemose May 22, 2024
0cfe4ac
fixed -source syntax
Evemose May 22, 2024
37535ae
Replaced @build with @compile
Evemose May 22, 2024
64280b4
Update ModuleImportProcessingTest.java
Evemose May 22, 2024
63d8423
Update ModuleImportProcessingTest.java
Evemose May 22, 2024
cf813cc
Added missing @
Evemose May 22, 2024
6b6e941
moved test to processing folder
Evemose May 23, 2024
3e4ec68
Merge remote-tracking branch 'origin/fix_module_imoprts_apt_fail' int…
Evemose May 23, 2024
a1eb82a
Addressed review comments
Evemose May 24, 2024
4084375
Overridden visitModuleImport in TreeTranslator
Evemose May 25, 2024
da9095d
Refactored test to use TestRunner
Evemose May 25, 2024
4846e8f
Addressed review
Evemose May 25, 2024
ba360ec
Addressed review (2)
Evemose May 25, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion test/langtools/tools/javac/annotations/8332497/T8332497.java
Original file line number Diff line number Diff line change
@@ -52,12 +52,15 @@ private void test() {
import javax.lang.model.element.TypeElement;
import javax.lang.model.SourceVersion;
@SupportedAnnotationTypes("*")
@SupportedSourceVersion(SourceVersion.RELEASE_23)
public class AP extends AbstractProcessor {
@Override
public boolean process(Set<? extends TypeElement> annotations, RoundEnvironment roundEnv) {
return false;
}
@Override
public SourceVersion getSupportedSourceVersion() {
return SourceVersion.latestSupported();
}
}
""";