-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8330846: Add stacks of mounted virtual threads to the HotSpot thread dump #19482
Closed
txominpelu
wants to merge
21
commits into
openjdk:master
from
txominpelu:txominpelu_8330846_add_stack_vthreads
+97
−0
Closed
Changes from 2 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
1a75277
8330846: Add stacks of mounted virtual threads to the HotSpot thread …
txominpelu ae690b2
Remove duplicated Carrying statement and indent vthread stack
txominpelu 47d7746
Merge remote-tracking branch 'upstream/master' into txominpelu_833084…
txominpelu 76e6e58
Add missing header
txominpelu 59b18db
Use JavaThread::print_vthread_stack_on
txominpelu 12a41a5
Update test/hotspot/jtreg/serviceability/dcmd/thread/PrintVirtualThre…
txominpelu 6a3b779
Add indentation for virtual thread stack
txominpelu 9acbf29
Print mounted virtual thread after carrier
txominpelu e619320
Fix copyright year
txominpelu b122cc0
Cleanup test
txominpelu 2cc4ba1
Remove extra indentation (leave it for the next PR)
txominpelu 7a57d05
Remove dead code
txominpelu a483113
Incorporate @tstuefe's remarks
txominpelu a97184c
Include virtual thread name in output
txominpelu ba3385a
Merge remote-tracking branch 'upstream/master' into txominpelu_833084…
txominpelu b1e61b2
Rename test
txominpelu 9591b28
Incorporate Alan's suggestions
txominpelu 69b7ec0
Require continuations to run the test
txominpelu 05d861c
Test fixes: pass to junit, avoid spinning thread on fail
txominpelu 4d6a8cc
Fix scope of the try block
txominpelu e2b8551
Remove unneeded line
txominpelu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1333,10 +1333,8 @@ void Threads::print_on(outputStream* st, bool print_stacks, | |
if (p->is_vthread_mounted()) { | ||
oop vt = p->vthread(); | ||
assert(vt != nullptr, ""); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please provide a valid assert string. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks ! I've fixed that in: a483113 |
||
st->print_cr(" \tMounted virtual thread #" INT64_FORMAT, (int64_t)java_lang_Thread::thread_id(vt)); | ||
st->inc(); | ||
st->print_cr(" Mounted virtual thread #" INT64_FORMAT, (int64_t)java_lang_Thread::thread_id(vt)); | ||
p->print_vthread_stack_on(st); | ||
st->dec(); | ||
} | ||
} | ||
} | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks ! I've fixed that in: a483113