Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8332423 : [PPC64] Remove C1_MacroAssembler::call_c_with_frame_resize #19947

Closed
wants to merge 12 commits into from
5 changes: 3 additions & 2 deletions src/hotspot/cpu/ppc/macroAssembler_ppc.hpp
Original file line number Diff line number Diff line change
@@ -364,10 +364,11 @@ class MacroAssembler: public Assembler {
// Call a C function via a function descriptor and use full C
// calling conventions. Updates and returns _last_calls_return_pc.
address call_c(Register function_descriptor);
address call_c(const FunctionDescriptor* function_descriptor, relocInfo::relocType rt);
address call_c(address function_entry, relocInfo::relocType rt = relocInfo::none) {
return call_c((FunctionDescriptor*)function_entry, rt);
return call_c((const FunctionDescriptor*)function_entry, rt);
}
// For tail calls: only branch, don't link, so callee returns to caller of this function.
// For tail calls: only branch, don't link, so callee returns to caller of this function.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks messed up! I requested to move it down, not do duplicate any function declaration. Also, the comment indentation is bad.

address call_c_and_return_to_caller(Register function_descriptor);
address call_c(const FunctionDescriptor* function_descriptor, relocInfo::relocType rt);
address call_c_using_toc(const FunctionDescriptor* function_descriptor, relocInfo::relocType rt,