8337221: CompileFramework: test library to conveniently compile java and jasm sources for fuzzing

test/hotspot/jtreg/compiler/lib/compile_framework/Compile.java

@@ -28,7 +28,7 @@
 import java.util.List;
 
 /**
- * Helper class for compilation of Java and Jasm {@code SourceCode}.
+ * Helper class for compilation of Java and Jasm {@link SourceCode}.
  */
 class Compile {
 

test/hotspot/jtreg/compiler/lib/compile_framework/CompileFramework.java

@@ -103,7 +103,7 @@
      * Access a class from the compiled code.
      *
      * @param name Name of the class to be retrieved.
-     * @return A class corresponding to the {@code name}.
+     * @return The class corresponding to the {@code name}.
      */
     public Class<?> getClass(String name) {
         try {
@@ -115,6 +115,7 @@
 
     /**
      * Invoke a static method from the compiled code.
+
      * @param className Class name of a compiled class.
      * @param methodName Method name of the class.
      * @param args List of arguments for the method invocation.
@@ -154,10 +155,10 @@
     }
 
     /**
-     * Returns the classpath appended with the {@code classesDir}, where
+     * Returns the classpath appended with the {@link classesDir}, where
      * the compiled classes are stored. This enables another VM to load
      * the compiled classes. Note, the string is already backslash escaped,
-     * so that the windows paths which use backslashes can be used directly
+     * so that Windows paths which use backslashes can be used directly
      * as strings.
      *
      * @return Classpath appended with the path to the compiled classes.
@@ -166,4 +167,3 @@
         return Utils.getEscapedClassPathAndClassesDir(classesDir);
     }
 }
-

test/hotspot/jtreg/compiler/lib/compile_framework/Utils.java

@@ -122,10 +122,10 @@ private static void writeCodeToFile(String code, Path path) {
     }
 
     /**
-     * Write sources to file.
+     * Write each source in {@code sources} to a file inside {@code sourceDir}.
      */
-    public static List<Path> writeSourcesToFile(List<SourceCode> sources, Path sourceDir) {
-        List<Path> storedFiles = new ArrayList<Path>();
+    public static List<Path> writeSourcesToFiles(List<SourceCode> sources, Path sourceDir) {
+        List<Path> storedFiles = new ArrayList<>();
         for (SourceCode sourceCode : sources) {
             Path path = sourceDir.resolve(sourceCode.filePathName());
             writeCodeToFile(sourceCode.code(), path);

test/hotspot/jtreg/testlibrary_tests/compile_framework/examples/CombinedJavaJasmExample.java

@@ -84,7 +84,7 @@ public static int mul3(int i) {
                """;
     }
 
-    public static void main(String args[]) {
+    public static void main(String[] args) {
         // Create a new CompileFramework instance.
         CompileFramework comp = new CompileFramework();
 
@@ -110,6 +110,5 @@ public static void test(CompileFramework comp, String className, String methodNa
         if (i != expected) {
             throw new RuntimeException("wrong value: " + i);
         }
-
     }
 }

test/hotspot/jtreg/testlibrary_tests/compile_framework/examples/IRFrameworkJavaExample.java

@@ -42,9 +42,9 @@
  * The "@compile" command for JTREG is required so that the IRFramework is compiled, other javac
  * might not compile it because it is not present in the class, only in the dynamically compiled
  * code.
- *
+ * <p>
  * Additionally, we must set the classpath for the Test-VM, so that it has access to all compiled
- * classes (see {@code getEscapedClassPathOfCompiledClasses}).
+ * classes (see {@link CompileFramework#getEscapedClassPathOfCompiledClasses}).
  */
 public class IRFrameworkJavaExample {
 
@@ -126,7 +126,7 @@ static void test_X2() {
         comp.compile();
 
         // Load the compiled class.
-        Class c = comp.getClass("X2");
+        Class<?> c = comp.getClass("X2");
 
         // Invoke the "X2.main" method from the compiled and loaded class.
         try {

test/hotspot/jtreg/testlibrary_tests/compile_framework/examples/MultiFileJavaExample.java

@@ -70,7 +70,6 @@ public static void main(String args[]) {
         // Compile the source files.
         comp.compile();
 
-
         // Object ret = XYZ9.test();
         Object ret = comp.invoke("p.xyz.XYZ9", "test", new Object[] {});