openjdk · stooke · Aug 22, 2024 · Sep 4, 2024 · Sep 4, 2024 · Sep 11, 2024
diff --git a/src/hotspot/share/services/diagnosticCommand.cpp b/src/hotspot/share/services/diagnosticCommand.cpp
@@ -1202,12 +1202,10 @@ void SystemDumpMapDCmd::execute(DCmdSource source, TRAPS) {
       output()->print_cr("(NMT is disabled, will not annotate mappings).");
     }
     MemMapPrinter::print_all_mappings(&fs);
-#ifndef _WIN64
     // For the readers convenience, resolve path name.
     char tmp[JVM_MAXPATHLEN];
     const char* absname = os::realpath(name, tmp, sizeof(tmp));
     name = absname != nullptr ? absname : name;
-#endif
     output()->print_cr("Memory map dumped to \"%s\".", name);
   } else {
     output()->print_cr("Failed to open \"%s\" for writing (%s).", name, os::strerror(errno));

diff --git a/test/hotspot/gtest/runtime/test_os.cpp b/test/hotspot/gtest/runtime/test_os.cpp
  static const char* nosuchpath = "/1234567890123456789";
  static const char* tmppath = "/tmp";

 	char buffer[MAX_PATH];

  errno = 0;
 	const char* returnedBuffer = os::realpath(nosuchpath, buffer, sizeof(nosuchpath) - 2);
  /* Returns ENOENT on Linux, ENAMETOOLONG on Windows */
  EXPECT_TRUE(returnedBuffer == nullptr);
  EXPECT_TRUE(errno == ENAMETOOLONG || errno == ENOENT);

  errno = 0;
 	returnedBuffer = os::realpath(nosuchpath, buffer, sizeof(nosuchpath) + 3);
  /* Returns ENOENT on Linux, 0 on Windows */
  EXPECT_TRUE(errno == 0 || errno == ENOENT);
  EXPECT_TRUE(returnedBuffer == nullptr || returnedBuffer == buffer);

 	errno = 0;
 	returnedBuffer = os::realpath(tmppath, buffer, MAX_PATH);
  EXPECT_TRUE(returnedBuffer == buffer);

  errno = 0;
  returnedBuffer = os::realpath(tmppath, buffer, strlen(tmppath) + 3); 
  EXPECT_TRUE(returnedBuffer == buffer);

  errno = 0;
	static const char* nosuchpath = "/1234567890123456789";
	static const char* tmppath = "/tmp";

	char buffer[MAX_PATH];
Check failure on line 417 in test/hotspot/gtest/runtime/test_os.cpp openjdk / jcheck-openjdk/jdk-20683 Whitespace error `Column 0: tab`

	errno = 0;
	const char* returnedBuffer = os::realpath(nosuchpath, buffer, sizeof(nosuchpath) - 2);
Check failure on line 420 in test/hotspot/gtest/runtime/test_os.cpp openjdk / jcheck-openjdk/jdk-20683 Whitespace error `Column 0: tab`
	/* Returns ENOENT on Linux, ENAMETOOLONG on Windows */
	EXPECT_TRUE(returnedBuffer == nullptr);
	EXPECT_TRUE(errno == ENAMETOOLONG \|\| errno == ENOENT);

	errno = 0;
	returnedBuffer = os::realpath(nosuchpath, buffer, sizeof(nosuchpath) + 3);
Check failure on line 426 in test/hotspot/gtest/runtime/test_os.cpp openjdk / jcheck-openjdk/jdk-20683 Whitespace error `Column 0: tab`
	/* Returns ENOENT on Linux, 0 on Windows */
	EXPECT_TRUE(errno == 0 \|\| errno == ENOENT);
	EXPECT_TRUE(returnedBuffer == nullptr \|\| returnedBuffer == buffer);

	errno = 0;
Check failure on line 431 in test/hotspot/gtest/runtime/test_os.cpp openjdk / jcheck-openjdk/jdk-20683 Whitespace error `Column 0: tab`
	returnedBuffer = os::realpath(tmppath, buffer, MAX_PATH);
Check failure on line 432 in test/hotspot/gtest/runtime/test_os.cpp openjdk / jcheck-openjdk/jdk-20683 Whitespace error `Column 0: tab`
	EXPECT_TRUE(returnedBuffer == buffer);

	errno = 0;
	returnedBuffer = os::realpath(tmppath, buffer, strlen(tmppath) + 3);
Check failure on line 436 in test/hotspot/gtest/runtime/test_os.cpp openjdk / jcheck-openjdk/jdk-20683 Whitespace error `Column 70: trailing whitespace`
	EXPECT_TRUE(returnedBuffer == buffer);

	errno = 0;