Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8319875: Add macOS implementation for jcmd System.map #20953

Closed
wants to merge 35 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
497759a
add windows implementation from PR
stooke Aug 28, 2024
b4525e4
add System.map stub to macos
stooke Aug 28, 2024
65067f2
basic region listing implemented
stooke Aug 29, 2024
92a0f58
more macos information
stooke Sep 11, 2024
cee46a8
fix whitespace errors
stooke Sep 11, 2024
870f7dd
add macOS to System.dump tests
stooke Sep 11, 2024
fa1babf
Merge branch 'master' into pr_macos_system_dump
stooke Sep 18, 2024
c5e93a0
add macOS to conditional compile
stooke Sep 19, 2024
69e380b
fix merge error
stooke Sep 19, 2024
60ed3af
fix macOS System.map tests
stooke Sep 20, 2024
47a01b1
Merge branch 'openjdk:master' into pr_macos_system_dump
stooke Oct 17, 2024
6426da7
add macOS to liast of supposredt platforms
stooke Oct 17, 2024
3050f9b
Merge branch 'master' into pr_macos_system_dump
stooke Oct 17, 2024
73fea75
refactor System.dump test for MacOS
stooke Oct 17, 2024
9292d71
more test cleanup
stooke Oct 17, 2024
0271eb1
fix whitespace
stooke Oct 18, 2024
a2cb3a0
initial release
stooke Oct 20, 2024
c6628d3
fix whitepsace errors
stooke Oct 24, 2024
7bbb03d
changes from review
stooke Oct 28, 2024
a16cc7b
changes from review
stooke Oct 29, 2024
a3a1a87
fix trailing whitespace
stooke Oct 29, 2024
6e368ae
fix xcode 16.1 compile error
stooke Oct 29, 2024
8e19b68
fix test for ZGC
stooke Oct 29, 2024
d63fa56
lowercase tag names, display dll addresses
stooke Nov 14, 2024
64a1f12
some rework and fix core dump
stooke Nov 15, 2024
3802126
change format strings to display all digits properly
stooke Nov 29, 2024
7fddda4
latest cleanup, get rid of dll info
stooke Dec 4, 2024
0718454
fix trailing whitesdpae errors
stooke Dec 4, 2024
c6c679a
combine like 128MB regions
stooke Dec 5, 2024
4e2dded
fix whitespace
stooke Dec 5, 2024
7b7c966
add constant
stooke Dec 6, 2024
b4c13ca
changes from revue
stooke Dec 9, 2024
0bdef60
whitespace error
stooke Dec 9, 2024
c2dc01c
fix crash due to uninitilized pointer
stooke Dec 9, 2024
c5cb0f9
Merge branch 'openjdk:master' into pr_macos_system_dump
stooke Dec 10, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/hotspot/os/bsd/memMapPrinter_macosx.cpp
Original file line number Diff line number Diff line change
@@ -210,14 +210,14 @@ class ProcSmapsSummary {

task_vm_info vm_info;
mach_msg_type_number_t num_out = TASK_VM_INFO_COUNT;
kern_return_t err_vm = task_info(mach_task_self(), TASK_VM_INFO, (task_info_t)(&vm_info), &num_out);
if (err_vm == KERN_SUCCESS) {
kern_return_t err = task_info(mach_task_self(), TASK_VM_INFO, (task_info_t)(&vm_info), &num_out);
if (err == KERN_SUCCESS) {
st->print_cr(" vsize: %llu (%llu%s)", vm_info.virtual_size, PROPERFMTARGS(vm_info.virtual_size));
st->print_cr(" rss: %llu (%llu%s)", vm_info.resident_size, PROPERFMTARGS(vm_info.resident_size));
st->print_cr(" peak rss: %llu (%llu%s)", vm_info.resident_size_peak, PROPERFMTARGS(vm_info.resident_size_peak));
st->print_cr(" page size: %d (%ld%s)", vm_info.page_size, PROPERFMTARGS((size_t)vm_info.page_size));
} else {
st->print_cr("error getting vm_info %d", err_vm);
st->print_cr("error getting vm_info %d", err);
}
st->print_cr(" private: %zu (" PROPERFMT ")", _private, PROPERFMTARGS(_private));
st->print_cr(" shared: %zu (" PROPERFMT ")", _shared, PROPERFMTARGS(_shared));