-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8341882: [BACKOUT] java/nio/file/attribute/BasicFileAttributeView/CreationTime.java#tmp fails on alinux3 #21441
Conversation
…ionTime.java#tmp fails on alinux3" This reverts commit 9d621d3.
👋 Welcome back chagedorn! A progress list of the required criteria for merging this PR into |
@chhagedorn This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
@chhagedorn The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
Thanks Tobias for the quick review! /integrate |
Going to push as commit 36fca5d. |
@chhagedorn Pushed as commit 36fca5d. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
JDK-8338884 is causing build failures on linux-x64 in tier1 in our CI:
Let's back this change out (pinging @sendaoYan). Revert was clean.
I created a REDO.
Thanks,
Christian
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21441/head:pull/21441
$ git checkout pull/21441
Update a local copy of the PR:
$ git checkout pull/21441
$ git pull https://git.openjdk.org/jdk.git pull/21441/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 21441
View PR using the GUI difftool:
$ git pr show -t 21441
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21441.diff