Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8343780: Add since checker tests to the Tools area modules and add missing @since to jdk.jfr #21982

Closed
wants to merge 7 commits into from
+151 −0
Closed

8343780: Add since checker tests to the Tools area modules and add missing @since to jdk.jfr #21982

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f64090b
8343780
nizarbenalla Nov 8, 2024
83afb01
remove backticks
nizarbenalla Nov 8, 2024
c1615b3
Add backticks, as they are necessary. Otherwise the `@since` is treat…
nizarbenalla Nov 14, 2024
180f9bb
Merge remote-tracking branch 'upstream/master' into add-since-test-tools
nizarbenalla Nov 29, 2024
83800e2
add missing line in jtreg comment
nizarbenalla Nov 29, 2024
091fb28
add a missing \@since tag to RecordingStream.onMetadata
nizarbenalla Nov 29, 2024
7858f99
Revert "add a missing \@since tag to RecordingStream.onMetadata"
nizarbenalla Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/jdk.jfr/share/classes/jdk/jfr/Recording.java
View file
Original file line number Diff line number Diff line change
@@ -97,6 +97,7 @@ public Map<String, String> toMap() {
* support, or if the file repository can't be created or accessed)
*
* @see jdk.jfr
* @since 11
*/
public Recording(Map<String, String> settings) {
Objects.requireNonNull(settings, "settings");
30 changes: 30 additions & 0 deletions test/jdk/tools/sincechecker/modules/java.scripting/JavaScriptingCheckSince.java
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
/*
* Copyright (c) 2024, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/

/*
* @test
* @bug 8343780
* @summary Test for `@since` in java.scripting module
* @library /test/lib /test/jdk/tools/sincechecker
* @run main SinceChecker java.scripting
*/
30 changes: 30 additions & 0 deletions test/jdk/tools/sincechecker/modules/jdk.dynalink/JdkDynalinkCheckSince.java
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
/*
* Copyright (c) 2024, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/

/*
* @test
* @bug 8343780
* @summary Test for `@since` in jdk.dynalik module
* @library /test/lib /test/jdk/tools/sincechecker
* @run main SinceChecker jdk.dynalink
*/
30 changes: 30 additions & 0 deletions test/jdk/tools/sincechecker/modules/jdk.jartool/JdkJartoolCheckSince.java
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
/*
* Copyright (c) 2024, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/

/*
* @test
* @bug 8343780
* @summary Test for `@since` in jdk.jartool module
* @library /test/lib /test/jdk/tools/sincechecker
* @run main SinceChecker jdk.jartool
*/
30 changes: 30 additions & 0 deletions test/jdk/tools/sincechecker/modules/jdk.jlink/JdkJlinkCheckSince.java
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
/*
* Copyright (c) 2024, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/

/*
* @test
* @bug 8343780
* @summary Test for `@since` in jdk.jlink module
* @library /test/lib /test/jdk/tools/sincechecker
* @run main SinceChecker jdk.jlink
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing "last" line?

Suggested change
* @run main SinceChecker jdk.jlink
* @run main SinceChecker jdk.jlink
*/

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right. Will update, thanks.

Copy link
Member Author

@nizarbenalla nizarbenalla Nov 29, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The copyright year was fixed after a merge.

*/
30 changes: 30 additions & 0 deletions test/jdk/tools/sincechecker/modules/jdk.jsobject/JdkJsobjectCheckSince.java
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
/*
* Copyright (c) 2024, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/

/*
* @test
* @bug 8343780
* @summary Test for `@since` in jdk.jsobject module
* @library /test/lib /test/jdk/tools/sincechecker
* @run main SinceChecker jdk.jsobject
*/