Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8343782: G1: Use one G1CardSet instance for multiple old gen regions #22015

Closed
wants to merge 32 commits into from
+1,071 −762
Closed

8343782: G1: Use one G1CardSet instance for multiple old gen regions #22015

Changes from 2 commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
4f56a90
revamp with retained regions added to groups
walulyai Oct 23, 2024
e6b1596
Merge remote-tracking branch 'upstream/master' into OldGenRemsetGroupsV1
walulyai Nov 5, 2024
834c598
remove MarkingSkipEvents
walulyai Nov 5, 2024
7a01f29
cleanup
walulyai Nov 7, 2024
e92e0be
Merge remote-tracking branch 'upstream/master' into OldGenRemsetGroupsV1
walulyai Nov 7, 2024
87ee3ba
more cleanups
walulyai Nov 7, 2024
b489c1d
add logging
walulyai Nov 11, 2024
9447a45
Merge remote-tracking branch 'upstream/master' into OldGenRemsetGroupsV1
walulyai Nov 11, 2024
4aa4d6b
Thomas Review
walulyai Nov 20, 2024
c3d7dda
Update src/hotspot/share/gc/g1/g1CollectionSet.cpp
walulyai Dec 2, 2024
e901227
Update src/hotspot/share/gc/g1/g1CollectionSetCandidates.hpp
walulyai Dec 2, 2024
4eec225
Update src/hotspot/share/gc/g1/g1_globals.hpp
walulyai Dec 2, 2024
fbff7d7
Update src/hotspot/share/gc/g1/g1CollectionSet.cpp
walulyai Dec 2, 2024
e687b0c
Albert Review
walulyai Dec 3, 2024
28e92c7
Merge remote-tracking branch 'upstream/master' into OldGenRemsetGroupsV1
walulyai Dec 4, 2024
65e9b21
Albert Review 2
walulyai Dec 9, 2024
e41c856
Print Group details in G1PrintRegionLivenessInfoClosure
walulyai Dec 11, 2024
f740a8e
Merge remote-tracking branch 'upstream/master' into OldGenRemsetGroupsV1
walulyai Dec 11, 2024
554b7f5
use reset_table_scanner_for_groups
walulyai Dec 11, 2024
ee59e0b
Merge remote-tracking branch 'upstream/master' into OldGenRemsetGroupsV1
walulyai Dec 13, 2024
e573b82
Thomas Review
walulyai Dec 13, 2024
633e3a2
assert
walulyai Dec 13, 2024
f0dce79
cleanup
walulyai Dec 13, 2024
ff5e9e0
fix space issues
walulyai Dec 13, 2024
08f5d3f
fix type
walulyai Dec 17, 2024
6194442
Merge remote-tracking branch 'upstream/master' into OldGenRemsetGroupsV1
walulyai Dec 17, 2024
1a27e5d
Merge remote-tracking branch 'upstream/master' into OldGenRemsetGroupsV1
walulyai Dec 19, 2024
c4887ed
Albert review
walulyai Dec 19, 2024
6a8039d
Merge remote-tracking branch 'upstream/master' into OldGenRemsetGroupsV1
walulyai Dec 19, 2024
403aad4
Merge remote-tracking branch 'upstream/master' into OldGenRemsetGroupsV1
walulyai Feb 4, 2025
d50457e
Revise Print Rememberedset info
walulyai Feb 5, 2025
5b43fdb
space
walulyai Feb 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/hotspot/share/gc/g1/g1ConcurrentMark.cpp
View file
Original file line number Diff line number Diff line change
@@ -3171,7 +3171,7 @@ void G1PrintRegionLivenessInfoClosure::do_cset_groups() {
G1PPRL_BYTE_FORMAT,
young_only_cset_group->group_id(), young_only_cset_group->length(),
"-",
0l, young_only_cset_group->card_set()->mem_size());
size_t(0), young_only_cset_group->card_set()->mem_size());

for (G1CSetCandidateGroup* group : g1h->policy()->candidates()->from_marking_groups()) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would skip retained groups, right? Is that intentional?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, retained regions are in "single region" groups, so all details should be added to the log when we call do_heap_region

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see; however, this would print the same gc_eff twice if young-gen contains a single region, right? Since this method is about cset-groups, I think it's more natural to visit all groups (regardless their size) here. With this PR, there is no gc_eff associated with individual region, do_heap_region can just skip gc_eff.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed, creating another issue; now we don't print details on humongous regions. I ask we fix that in a follow up.

log_trace(gc, liveness)(G1PPRL_LINE_PREFIX