Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8341916: Remove ProtectionDomain related hotspot code and tests #22064

Closed
wants to merge 10 commits into from
+169 −1,415
Closed

8341916: Remove ProtectionDomain related hotspot code and tests #22064

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
e42f69d
8341916: Remove ProtectionDomain related hotspot code and tests
coleenp Oct 18, 2024
c7b5fd1
Remove some more includes.
coleenp Nov 12, 2024
ebf5ed7
David comments.
coleenp Nov 14, 2024
79831e0
More purging of AccessController, AccessControlContext and some stack…
coleenp Nov 14, 2024
11337a0
Found more obsolete security manager code.
coleenp Nov 14, 2024
ca34fc5
More obsolete code. Fix trace_class_resolution (doesn't throw except…
coleenp Nov 14, 2024
aee8efd
Purge last references to SecurityManager.
coleenp Nov 14, 2024
05d0251
Merge branch 'master' into protection-domain
coleenp Nov 15, 2024
14e11e5
Handle merge conflicts in new resolve_instance_class calls.
coleenp Nov 15, 2024
dd1766e
Fix comments.
coleenp Nov 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/hotspot/share/classfile/vmClassMacros.hpp
View file
Original file line number Diff line number Diff line change
@@ -60,7 +60,6 @@
do_klass(Error_klass, java_lang_Error ) \
do_klass(Exception_klass, java_lang_Exception ) \
do_klass(RuntimeException_klass, java_lang_RuntimeException ) \
do_klass(SecurityManager_klass, java_lang_SecurityManager ) \
do_klass(ProtectionDomain_klass, java_security_ProtectionDomain ) \
do_klass(SecureClassLoader_klass, java_security_SecureClassLoader ) \
do_klass(ClassNotFoundException_klass, java_lang_ClassNotFoundException ) \
1 change: 0 additions & 1 deletion src/hotspot/share/classfile/vmSymbols.hpp
View file
Original file line number Diff line number Diff line change
@@ -117,7 +117,6 @@ class SerializeClosure;
template(java_lang_reflect_RecordComponent, "java/lang/reflect/RecordComponent") \
template(java_lang_StringBuffer, "java/lang/StringBuffer") \
template(java_lang_StringBuilder, "java/lang/StringBuilder") \
template(java_lang_SecurityManager, "java/lang/SecurityManager") \
template(java_lang_ScopedValue, "java/lang/ScopedValue") \
template(java_lang_ScopedValue_Carrier, "java/lang/ScopedValue$Carrier") \
template(java_security_CodeSource, "java/security/CodeSource") \
3 changes: 1 addition & 2 deletions src/hotspot/share/logging/logDiagnosticCommand.hpp
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2015, 2023, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2015, 2024, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -59,7 +59,6 @@ class LogDiagnosticCommand : public DCmdWithParser {
return "Lists current log configuration, enables/disables/configures a log output, or rotates all logs.";
}

// Used by SecurityManager. This DCMD requires ManagementPermission = control.
static const JavaPermission permission() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is any of this permission stuff still relevant? I couldn't figure out what ultimately looks at them. ??

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know that. It is passed by the MBean code. It might be another (different) opportunity for a cleanup if the MBean code doesn't use it anymore.

JavaPermission p = {"java.lang.management.ManagementPermission", "control", nullptr};
return p;