Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8344365: SecurityManager cleanups in java.sql and java.sql.rowset modules #22185

Closed
wants to merge 12 commits into from
+54 −397
Closed

8344365: SecurityManager cleanups in java.sql and java.sql.rowset modules #22185

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
2c27a3c
SecurityManager-related cleanups for java.sql and java.sql.rowset
eirbjo Nov 17, 2024
1944bee
Remove @SuppressWarnings("removal")
eirbjo Nov 17, 2024
db0f141
Remove call to ReflectUtil::checkPackageAccess
eirbjo Nov 17, 2024
115440c
Inline call to Class.forName
eirbjo Nov 17, 2024
bdca04f
Remove calls to ReflectUtil.checkPackageAccess
eirbjo Nov 17, 2024
6c2b039
Update copyright
eirbjo Nov 17, 2024
6d8f1a3
Remove unused SQLPermission constants
eirbjo Nov 17, 2024
d45c5ec
Remove unused class TestPolicy from test/java/sql/testng/util
eirbjo Nov 17, 2024
11145fc
SerialJavaObject::getFields is no longer @CallerSensitive, remove it …
eirbjo Nov 18, 2024
d539a31
Revert caller-sensitive inlining of ReflectUtil.forName
eirbjo Nov 18, 2024
3f1df59
Merge branch 'master' into sm-cleanup-sql
eirbjo Nov 18, 2024
0278c59
Remove ObjectStreamField#getType from UNSUPPORTED_VIRTUAL_METHODS, a …
eirbjo Nov 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions test/jdk/jdk/internal/reflect/CallerSensitive/CheckCSMs.java
View file
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your mailing list message recommends removal of this test. This test covers more than ensuring that CSMs are final or static; it actually scans all platform classes to ensure CSMs are present wherever they are needed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I'll leave the test with the empty set as suggested by Roger.

Original file line number Diff line number Diff line change
@@ -76,8 +76,7 @@ public class CheckCSMs {

// These non-static non-final methods must not have @CallerSensitiveAdapter
// methods that takes an additional caller class parameter.
private static Set<String> UNSUPPORTED_VIRTUAL_METHODS =
Set.of("java/io/ObjectStreamField#getType (Ljava/lang/Class;)Ljava/lang/Class;");
private static Set<String> UNSUPPORTED_VIRTUAL_METHODS = Set.of();

public static void main(String[] args) throws Exception {
if (args.length > 0 && args[0].equals("--list")) {