Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8345217: Parallel: Refactor PSParallelCompact::next_src_region #22441

Closed
wants to merge 1 commit into from
+3 −10
Closed

8345217: Parallel: Refactor PSParallelCompact::next_src_region #22441

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 3 additions & 10 deletions src/hotspot/share/gc/parallel/psParallelCompact.cpp
View file
Original file line number Diff line number Diff line change
@@ -2137,13 +2137,9 @@ size_t PSParallelCompact::next_src_region(MoveAndUpdateClosure& closure,
}

if (src_region_ptr < top_region_ptr) {
// The next source region is in the current space. Update src_region_idx
// and the source address to match src_region_ptr.
// Found the first non-empty region in the same space.
src_region_idx = sd.region(src_region_ptr);
HeapWord* const src_region_addr = sd.region_to_addr(src_region_idx);
if (src_region_addr > closure.source()) {
closure.set_source(src_region_addr);
}
closure.set_source(sd.region_to_addr(src_region_idx));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to make sure I understand: the only change here is the removal of the condition src_region_addr > closure.source() because at worst we can set the same value into closure._source anyway, and the additional check is kind of superfluous.

return src_region_idx;
}

@@ -2167,13 +2163,10 @@ size_t PSParallelCompact::next_src_region(MoveAndUpdateClosure& closure,
RegionData* cur = sd.region(cur_region);
if (cur->live_obj_size() > 0) {
HeapWord* region_start_addr = sd.region_to_addr(cur_region);
HeapWord* region_end_addr = region_start_addr + ParallelCompactData::RegionSize;
HeapWord* first_live_word = mark_bitmap()->find_obj_beg(region_start_addr, region_end_addr);
assert(first_live_word < region_end_addr, "inv");

src_space_id = SpaceId(space_id);
src_space_top = top;
closure.set_source(first_live_word);
closure.set_source(region_start_addr);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason for removing the search for the first live word is because all callers will scan the bitmap anyway?

return cur_region;
}
}