Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8323740: java.lang.ExceptionInInitializerError when trying to load XML classes in wrong order #22803

Closed
wants to merge 3 commits into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/java.xml/share/classes/jdk/xml/internal/JdkXmlUtils.java
Original file line number Diff line number Diff line change
@@ -94,7 +94,9 @@ public class JdkXmlUtils {
/**
* The system-default factory
*/
private static final SAXParserFactory defaultSAXFactory = getSAXFactory(false);
private static class DefaultSAXFactory {
private static final SAXParserFactory instance = getSAXFactory(false);
}

/**
* Returns the value.
@@ -322,7 +324,7 @@ public static XMLReader getXMLReader(XMLSecurityManager sm,
}
} else {
// use the system-default
saxFactory = defaultSAXFactory;
saxFactory = DefaultSAXFactory.instance;

try {
reader = saxFactory.newSAXParser().getXMLReader();
42 changes: 42 additions & 0 deletions test/jdk/javax/xml/jaxp/common/8323740/InitializerTest.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
/*
* Copyright (c) 2024, Google LLC. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/

import org.testng.annotations.Test;

import java.util.Objects;

/**
* @test
*
* @bug 8323740
* @summary test that class initializers don't crash
* @run testng/othervm InitializerTest
*/
public class InitializerTest {

@Test
public void testXMLOutputFactory() throws Exception {
String name = "com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl";
Objects.requireNonNull(Class.forName(name));
}
}