Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8349525: RBTree: provide leftmost, rightmost, and a simple way to print trees #23486

Closed
wants to merge 4 commits into from
+253 −75
Closed

8349525: RBTree: provide leftmost, rightmost, and a simple way to print trees #23486

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ce35dc6
RBTree: leftmost, rightmost, print_on
tstuefe Feb 5, 2025
56fbca4
fix constness, lp64 issues
tstuefe Feb 6, 2025
c96cfa3
feedback johan
tstuefe Feb 7, 2025
4f9eddb
feedback caspar
tstuefe Feb 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions test/hotspot/gtest/utilities/test_rbtree.cpp
View file
Original file line number Diff line number Diff line change
@@ -414,7 +414,6 @@ using RBTreeInt = RBTreeCHeap<int, int, Cmp, mtOther>;
min = MIN2(min, r);
max = MAX2(max, r);
}
// rbtree_const.print_on(tty);
// Explicitly test non-const variants
Node* n = rbtree.rightmost();
ASSERT_EQ(n->key(), max);
@@ -554,7 +553,7 @@ struct PtrCmp {
};

TEST_VM(RBTreeTestNonFixture, TestPrintPointerTree) {
typedef RBTree<const void*, unsigned, PtrCmp, RBTreeCHeapAllocator<mtTest> > TreeType;
typedef RBTreeCHeap<const void*, unsigned, PtrCmp, mtTest> TreeType;
TreeType tree;
#ifdef _LP64
const void* const p1 = (const void*) 0x800000000ULL;