Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8350685: java/lang/System/SecurityManagerWarnings.java fails with --enable-preview #23864

Closed
wants to merge 1 commit into from
+4 −5
Closed

8350685: java/lang/System/SecurityManagerWarnings.java fails with --enable-preview #23864

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions test/jdk/java/lang/System/SecurityManagerWarnings.java
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2021, 2024, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2021, 2025, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -53,8 +53,7 @@ public static void main(String args[]) throws Exception {

JarUtils.createJarFile(Path.of("a.jar"),
Path.of(testClasses),
Path.of("SecurityManagerWarnings.class"),
Path.of("A.class"));
Path.of(testClasses));

failLateTest(null, "a.jar");
} else {
@@ -72,8 +71,8 @@ public static void main(String args[]) throws Exception {
}
}

// When -Djava.security.manager is not set, or set to "allow",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment was incorrect. Setting "allow" now causes the JVM to fail with an error.

// or "disallow", JVM starts but setSecurityManager will fail.
// When -Djava.security.manager is not set or set to "disallow",
// JVM starts but setSecurityManager will fail.
static void failLateTest(String prop, String cp) throws Exception {
run(prop, cp)
.shouldNotHaveExitValue(0)