Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8351464: Shenandoah: Hang on ShenandoahController::handle_alloc_failure when run test TestAllocHumongousFragment#generational #23997

Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/hotspot/share/gc/shenandoah/shenandoahControlThread.cpp
Original file line number Diff line number Diff line change
@@ -167,8 +167,8 @@ void ShenandoahControlThread::run_service() {
notify_gc_waiters();
}

// If this was the allocation failure GC cycle, notify waiters about it
if (alloc_failure_pending) {
// If this cycle completed without being cancelled, notify waiters about it
if (!heap->cancelled_gc()) {
notify_alloc_failure_waiters();
}

Original file line number Diff line number Diff line change
@@ -277,8 +277,8 @@ void ShenandoahGenerationalControlThread::run_gc_cycle(const ShenandoahGCRequest
notify_gc_waiters();
}

// If this was an allocation failure GC cycle, notify waiters about it
if (ShenandoahCollectorPolicy::is_allocation_failure(request.cause)) {
// If this cycle completed successfully, notify threads waiting to retry allocation
if (!_heap->cancelled_gc()) {
notify_alloc_failure_waiters();
}

1 change: 0 additions & 1 deletion test/hotspot/jtreg/ProblemList.txt
Original file line number Diff line number Diff line change
@@ -97,7 +97,6 @@ gc/TestAlwaysPreTouchBehavior.java#Z 8334513 generic-all
gc/TestAlwaysPreTouchBehavior.java#Epsilon 8334513 generic-all
gc/shenandoah/oom/TestAllocOutOfMemory.java#large 8344312 linux-ppc64le
gc/shenandoah/TestEvilSyncBug.java#generational 8345501 generic-all
gc/TestAllocHumongousFragment.java#generational 8351464 generic-all

#############################################################################