Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8351096: Typos in Vector API doc #24065

Closed
wants to merge 1 commit into from
Closed

Conversation

igraves
Copy link
Member

@igraves igraves commented Mar 14, 2025

Improvements and fixes to grammar, spelling, and punctuation issues in the Vector API docs.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8351096: Typos in Vector API doc (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24065/head:pull/24065
$ git checkout pull/24065

Update a local copy of the PR:
$ git checkout pull/24065
$ git pull https://git.openjdk.org/jdk.git pull/24065/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24065

View PR using the GUI difftool:
$ git pr show -t 24065

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24065.diff

Sorry, something went wrong.

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 14, 2025

👋 Welcome back igraves! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 14, 2025

@igraves This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8351096: Typos in Vector API doc

Reviewed-by: psandoz

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

  • 7f42804: 8350524: Some hotspot/jtreg/serviceability/dcmd/vm tier1 tests fail on static JDK
  • 712a70c: 8318220: RISC-V: C2 ReverseI
  • 985ca12: 8352011: RISC-V: Two IR tests fail after JDK-8351662
  • 86b2433: 8352050: Problem list compiler/ciReplay/* test until JDK-8349191 is fixed
  • 65c5282: 8351938: C2: Print compilation bailouts with PrintCompilation compile command
  • e3c29c9: 8351556: Optimize Location.locationFor/isModuleOrientedLocation
  • a7a09f6: 8349632: RISC-V: Add Zfa fminm/fmaxm
  • 0454406: 8351987: ProblemList the failing JFR streaming tests on macOS
  • be36b23: 8351778: JIT compiler fails when running -XX:AOTMode=create

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title JDK-8351096: Typos in Vector API doc 8351096: Typos in Vector API doc Mar 14, 2025
@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 14, 2025
@openjdk
Copy link

openjdk bot commented Mar 14, 2025

@igraves To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • graal
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

Copy link
Member

@PaulSandoz PaulSandoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 14, 2025
@igraves
Copy link
Member Author

igraves commented Mar 14, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Mar 14, 2025

Going to push as commit 0460978.
Since your change was applied there have been 9 commits pushed to the master branch:

  • 7f42804: 8350524: Some hotspot/jtreg/serviceability/dcmd/vm tier1 tests fail on static JDK
  • 712a70c: 8318220: RISC-V: C2 ReverseI
  • 985ca12: 8352011: RISC-V: Two IR tests fail after JDK-8351662
  • 86b2433: 8352050: Problem list compiler/ciReplay/* test until JDK-8349191 is fixed
  • 65c5282: 8351938: C2: Print compilation bailouts with PrintCompilation compile command
  • e3c29c9: 8351556: Optimize Location.locationFor/isModuleOrientedLocation
  • a7a09f6: 8349632: RISC-V: Add Zfa fminm/fmaxm
  • 0454406: 8351987: ProblemList the failing JFR streaming tests on macOS
  • be36b23: 8351778: JIT compiler fails when running -XX:AOTMode=create

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 14, 2025
@openjdk openjdk bot closed this Mar 14, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 14, 2025
@openjdk
Copy link

openjdk bot commented Mar 14, 2025

@igraves Pushed as commit 0460978.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

None yet

2 participants