Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8352185: Shenandoah: Invalid logic for remembered set verification #24092

Closed
wants to merge 21 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
d7d0f30
Initial works
pengxiaolong Mar 12, 2025
7f87ab7
Always swap card table in generational mode so the table can be prope…
pengxiaolong Mar 17, 2025
d55f9a1
Only clean rem-set read table in young gc; not verify rem-set in conc…
pengxiaolong Mar 18, 2025
45d58df
Set mark incomplete after ShenandoahMCResetCompleteBitmapTask
pengxiaolong Mar 18, 2025
5a94b14
Clean and rebuild rem-set in global gc
pengxiaolong Mar 18, 2025
021f2fe
Address review comments
pengxiaolong Mar 19, 2025
4726b87
Merge branch 'openjdk:master' into JDK-8345399-v3
pengxiaolong Mar 19, 2025
f16dd72
remembered set can't be verified w/o complete old marking or parsable…
pengxiaolong Mar 20, 2025
6c420c4
Merge branch 'master' of https://github.com/openjdk/jdk into JDK-8345…
pengxiaolong Mar 20, 2025
3947f36
Fix test failure
pengxiaolong Mar 20, 2025
f0e8d69
set old gen parsable to false when complete mixed evacuations
pengxiaolong Mar 20, 2025
b1b9350
Not verify rem-set before init-mark in global gc
pengxiaolong Mar 20, 2025
e332724
Revert "set old gen parsable to false when complete mixed evacuations"
pengxiaolong Mar 20, 2025
2b53863
Use read table for verify_rem_set_before_mark
pengxiaolong Mar 20, 2025
2a7fa4b
Use decode_raw instead of decode_not_null
pengxiaolong Mar 20, 2025
feceef3
Not verify remembered set w/o parseable old gen when old mark is inco…
pengxiaolong Mar 20, 2025
39707d1
Fix wrong comments
pengxiaolong Mar 20, 2025
27cc142
Use decode_raw_not_null instead of decode_raw
pengxiaolong Mar 20, 2025
73e95e8
Not validate remembered set w/o complete old marking
pengxiaolong Mar 20, 2025
16494d4
tide up
pengxiaolong Mar 20, 2025
e11c6fc
Add comments
pengxiaolong Mar 21, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -792,6 +792,7 @@ void ShenandoahOldGeneration::complete_mixed_evacuations() {
}

if (state() == ShenandoahOldGeneration::EVACUATING) {
set_parsable(false);
transition_to(ShenandoahOldGeneration::FILLING);
return;
}