Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8284858: Start of release updates for JDK 20 #8236

Closed
wants to merge 44 commits into from

Conversation

jddarcy
Copy link
Member

@jddarcy jddarcy commented Apr 14, 2022

Time to start getting ready for JDK 20...


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issues

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8236/head:pull/8236
$ git checkout pull/8236

Update a local copy of the PR:
$ git checkout pull/8236
$ git pull https://git.openjdk.java.net/jdk pull/8236/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8236

View PR using the GUI difftool:
$ git pr show -t 8236

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8236.diff

@jddarcy jddarcy marked this pull request as draft April 14, 2022 05:09
@bridgekeeper
Copy link

bridgekeeper bot commented Apr 14, 2022

👋 Welcome back darcy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 14, 2022

@jddarcy The following labels will be automatically applied to this pull request:

  • build
  • compiler
  • core-libs
  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added hotspot-runtime hotspot-runtime-dev@openjdk.org build build-dev@openjdk.org core-libs core-libs-dev@openjdk.org compiler compiler-dev@openjdk.org labels Apr 14, 2022
Copy link
Contributor

@jonathan-gibbons jonathan-gibbons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

langtools files look OK, although I did skim through the auto-generated new data/symbols files.

There are possibilities in the langtools file to simplify naming and default initialization of member fields in various places, in a separate PR, separate from these changes.

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates look good. Thanks

Copy link
Member

@irisclark irisclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes still look good.

Copy link
Member

@magicus magicus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build changes look good. Thanks for fixing the bug in generate-symbol-data.sh.

@jddarcy
Copy link
Member Author

jddarcy commented Jun 9, 2022

/integrate defer

@openjdk openjdk bot added the deferred label Jun 9, 2022
@openjdk
Copy link

openjdk bot commented Jun 9, 2022

@jddarcy Integration of this pull request has been deferred and may be completed by any project committer using the /integrate pull request command.

@erikj79
Copy link
Member

erikj79 commented Jun 9, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Jun 9, 2022

Going to push as commit edff51e.
Since your change was applied there have been 14 commits pushed to the master branch:

  • 2671443: 8286171: HttpClient/2 : Expect:100-Continue blocks indefinitely when response is not 100
  • 59b0de6: 8288048: Build failure with GCC 6 after JDK-8286562
  • db4405d: 8288078: linux-aarch64-optimized build fails in Tier5 after JDK-8287567
  • 7e948f7: 8287903: Reduce runtime of java.math microbenchmarks
  • 3fa9984: 8287854: Dangling reference in ClassVerifier::verify_class
  • 4285e3d: 8288023: AArch64: disable PAC-RET when preview is enabled
  • 560e292: 8287738: [PPC64] jdk/incubator/vector/*VectorTests failing
  • e5b56ba: 8288040: x86: Loom: Improve cont/monitor-count helper methods
  • 5a89cb0: 6429812: NPE after calling JTable.updateUI() when using a header renderer + XP L&F
  • bc28bae: 8287897: Augment src/jdk.internal.le/share/legal/jline.md with information on 4th party dependencies
  • ... and 4 more: https://git.openjdk.org/jdk/compare/a941bc2de674fdd77cdbbdf3641309fc39bfc0c4...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 9, 2022
@openjdk openjdk bot closed this Jun 9, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review deferred labels Jun 9, 2022
@openjdk
Copy link

openjdk bot commented Jun 9, 2022

@erikj79 Pushed as commit edff51e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build-dev@openjdk.org compiler compiler-dev@openjdk.org core-libs core-libs-dev@openjdk.org hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
7 participants