8286623: Bundle zlib by default with JDK on macos aarch64

[jaikiran]

Can I please get a review of this change to the build system which now makes bundled zlib as the default for macos aarch64 systems?

We have been running into various intermittent failures on macos aarch64 systems for several months now. After investigation we have been able to ascertain that the root cause of the issue lies within the zlib that's shipped on macos aarch64 systems. The complete details about that issue is available at https://bugs.openjdk.java.net/browse/JDK-8282954.
We have filed a bug with Apple for their inputs on what we can do to fix it in that shipped library. Given the nature of that issue, we don't have a timeline on when/if the solution for that will be available. Until that time, at least, the proposal is to use bundled zlib (which doesn't reproduce those failures) by default on macos aarch64.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (1 review required, with at least 1 reviewer)

Issue

• JDK-8286623: Bundle zlib by default with JDK on macos aarch64

Reviewers

• Lance Andersen (@LanceAndersen - Reviewer)
• Magnus Ihse Bursie (@magicus - Reviewer)
• Erik Joelsson (@erikj79 - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8675/head:pull/8675
$ git checkout pull/8675

Update a local copy of the PR:
$ git checkout pull/8675
$ git pull https://git.openjdk.java.net/jdk pull/8675/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8675

View PR using the GUI difftool:
$ git pr show -t 8675

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8675.diff

[bridgekeeper]

👋 Welcome back jpai! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jaikiran The following label will be automatically applied to this pull request:

• build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[jaikiran]

/label core-libs

[mlbridge]

Webrevs

• 00: Full (32fd6a51)

[openjdk]

@jaikiran
The core-libs label was successfully added.

[jaikiran]

Dummy comment to initiate a mail to core-libs mailing list too.

[LanceAndersen]

Hi Jai,

Thank you for your efforts with testing and reaching out to Apple.

Given we do not see the issue with the bundled zlib, this is our best path forward for stability on macOS aarch64.

Once we can determine the cause with the help of Apple, we can switch back to the zlib that comes with macOS on this platform.

[openjdk]

@jaikiran This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8286623: Bundle zlib by default with JDK on macos aarch64

Reviewed-by: lancea, ihse, erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

• dea6e88: 8284680: sun.font.FontConfigManager.getFontConfig() leaks charset
• 40f43c6: 8286601: Mac Aarch: Excessive warnings to be ignored for build jdk
• be97b4b: 8278348: [macos12] javax/swing/JTree/4908142/bug4908142.java fails in macos12
• ff17f49: 8284888: [macos] javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java failed with "NimbusLookAndFeel] : ERROR: icon and imageIcon not same."

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[magicus]

LGTM

[jaikiran]

Thank you everyone for the reviews.

[jaikiran]

/integrate

[openjdk]

Going to push as commit c3bade2.
Since your change was applied there have been 23 commits pushed to the master branch:

• 617ef54: 8286647: JFR: Build failure when C1 or C2 is disabled after JDK-8282420
• 369611e: 8286677: [BACKOUT] (fc) Tune FileChannel.transferFrom()
• 4b8a66a: 8286424: GetVersionEx is deprecated
• 986d87d: 8274113: (fc) Tune FileChannel.transferFrom()
• 61cb4b7: 8285951: Replace Algorithms.eatMemory(...) with WB.fullGC() in vmTestbase_vm_gc_ref tests
• 5ff1d22: 8286386: Address possibly lossy conversions in java.net.http
• 7118343: 8278262: JFR: TestPrintXML can't handle missing timestamps
• 74eee28: 8286560: Remove user parameter from jdk.internal.perf.Perf.attach()
• 160944b: 8286615: Small refactor to SerializedLambda
• 17c5278: 8286378: Address possibly lossy conversions in java.base
• ... and 13 more: https://git.openjdk.java.net/jdk/compare/50d47de8358e2f22bf3a4a165d660c25ef6eacbc...master

Your commit was automatically rebased without conflicts.

[openjdk]

@jaikiran Pushed as commit c3bade2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[mrserb]

@jaikiran Do you have a plan to backport this fix to the 17 and below?

[jaikiran]

Hello Sergey, there's currently no plan to backport this. We are hoping to hear back from Apple for the root cause issue that we have filed.