Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JDK-8288207: Enhance MalformedURLException in Uri.parseCompat #9126

Closed
wants to merge 4 commits into from
Closed

JDK-8288207: Enhance MalformedURLException in Uri.parseCompat #9126

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2454d4e
JDK-8288207
MBaesken Jun 10, 2022
1050c72
Adjust exception text to the suggestion of Daniel Fuchs
MBaesken Jun 14, 2022
bdbe220
fix copy paste error
MBaesken Jun 14, 2022
8f52822
avoid very long line
MBaesken Jun 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/java.naming/share/classes/com/sun/jndi/toolkit/url/Uri.java
View file
Open in desktop
Expand Up @@ -364,7 +364,8 @@ private void parseCompat(String uri) throws MalformedURLException {
+ (port == -1?"":(":" + port));
if (!auth.equals(hostport)) {
// throw if we have user info or regname
throw new MalformedURLException("unsupported authority: " + auth);
throw new MalformedURLException("Authority component is not server-based, " +
"or contains user info. Unsupported authority: " + auth);
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks okay but you may have to split up the line to avoid adding a 150+ char line (most of the file seems to keep the lines under 100 or so).

} catch (URISyntaxException e) {
var mue = new MalformedURLException(e.getMessage());
Expand Down