Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8267860: Off-by-one bug when searching arrays in AlpnGreaseTest #9131

Closed
wants to merge 3 commits into from
Closed

8267860: Off-by-one bug when searching arrays in AlpnGreaseTest #9131

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
83e1d23
JDK-8267860: off-by-one error
driverkt Jun 10, 2022
507abec
Update AlpnGreaseTest.java
driverkt Jun 10, 2022
11379da
Merge branch 'openjdk:master' into JDK-8267860
driverkt Jun 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/jdk/sun/security/ssl/ALPN/AlpnGreaseTest.java
View file
Open in desktop
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2020, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2020, 2022, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
Expand Down Expand Up @@ -83,7 +83,7 @@ public class AlpnGreaseTest implements SSLContextTemplate {
new String(greaseBytes, StandardCharsets.ISO_8859_1);

private static void findGreaseInClientHello(byte[] bytes) throws Exception {
for (int i = 0; i < bytes.length - greaseBytes.length; i++) {
for (int i = 0; i < bytes.length - greaseBytes.length + 1; i++) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

if (Arrays.equals(bytes, i, i + greaseBytes.length,
greaseBytes, 0, greaseBytes.length)) {
System.out.println("Found greaseBytes in ClientHello at: " + i);
Expand Down