Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8287868: Localized names update in COMPAT locale provider #9134

Closed
wants to merge 3 commits into from

Conversation

naotoj
Copy link
Member

@naotoj naotoj commented Jun 10, 2022

As the name suggests, COMPAT locale provider keeps compatibility with JDK8's locale data (before CLDR). This is useful for legacy applications, but some of its data got obsolete for later locale data updates, such as the country name change for Eswatini (formerly known as Swaziland). This PR is to fix those names up-to-date from CLDR. More specifically, changes are made for language, country, script display names in Locale class, and Currency display names. Localized names used for TimeZones and Currency symbols (such as $) are not modified so that format/parse should work as with JDK8.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8287868: Localized names update in COMPAT locale provider

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9134/head:pull/9134
$ git checkout pull/9134

Update a local copy of the PR:
$ git checkout pull/9134
$ git pull https://git.openjdk.org/jdk pull/9134/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9134

View PR using the GUI difftool:
$ git pr show -t 9134

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9134.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 10, 2022

👋 Welcome back naoto! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 10, 2022
@openjdk
Copy link

openjdk bot commented Jun 10, 2022

@naotoj The following labels will be automatically applied to this pull request:

  • core-libs
  • i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org labels Jun 10, 2022
@mlbridge
Copy link

mlbridge bot commented Jun 10, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Jun 21, 2022

@naotoj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8287868: Localized names update in COMPAT locale provider

Reviewed-by: iris, joehw

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 115 new commits pushed to the master branch:

  • 535fba8: 8288687: (fc) Unix version ofFileChannelImpl.transferTo0() should should return IOS_UNSUPPORTED if not Linux, macOS, nor AIX
  • 1901735: 8288209: SSL debug message wrong about unsupported authentication scheme
  • 0f801fe: 8288628: Unnecessary Hashtable usage in ConditionalSpecialCasing
  • 701ea3b: 8288556: VM crashes if it gets sent SIGUSR2 from outside
  • 5e680d0: 8288724: Prevent NullPointerException in serviceability/tmtools/jstack/DaemonThreadTest.java if jstack process fails
  • ad89146: 8288601: Consolidate static/dynamic archive tables
  • 7e211d7: 8287672: jtreg test com/sun/jndi/ldap/LdapPoolTimeoutTest.java fails intermittently in nightly run
  • 7039c66: Merge
  • 453e8be: 8288527: broken link in java.base/java/util/zip/package-summary.html
  • 33d0363: 8288741: JFR: Change package name of snippet files
  • ... and 105 more: https://git.openjdk.org/jdk/compare/c6dd2ab9d72298b1e25ee811b1e200f6a0fdc933...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 21, 2022
@mlbridge
Copy link

mlbridge bot commented Jun 21, 2022

Mailing list message from Naoto Sato on i18n-dev:

Ping.

Naoto

On 6/10/22 2:05 PM, Naoto Sato wrote:

@naotoj
Copy link
Member Author

naotoj commented Jun 22, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Jun 22, 2022

Going to push as commit d4de475.
Since your change was applied there have been 133 commits pushed to the master branch:

  • 50c37f5: 8276798: HttpURLConnection sends invalid HTTP request
  • 270cf67: 8288752: Split thread implementation files
  • d51f4f4: 8287011: Improve container information
  • affbd72: 8288744: Remove tools/jlink/plugins/CompressorPluginTest.java from problemlist
  • 2bf5c9a: Merge
  • 70008da: 8287971: Throw exception for missing values in .jpackage.xml
  • d7b43af: 8288761: SegmentAllocator:allocate(long bytesSize) not throwing IAEx when bytesSize < 0
  • 834d92d: 8288754: GCC 12 fails to build zReferenceProcessor.cpp
  • 198cec9: 8286103: VThreadMonitorTest fails "assert(!current->cont_fastpath() || (current->cont_fastpath_thread_state() && !interpreted_native_or_deoptimized_on_stack(current))) failed"
  • 97200a7: 8278053: serviceability/jvmti/vthread/ContStackDepthTest/ContStackDepthTest.java failing in loom repo with Xcomp
  • ... and 123 more: https://git.openjdk.org/jdk/compare/c6dd2ab9d72298b1e25ee811b1e200f6a0fdc933...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 22, 2022
@openjdk openjdk bot closed this Jun 22, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 22, 2022
@openjdk
Copy link

openjdk bot commented Jun 22, 2022

@naotoj Pushed as commit d4de475.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org integrated Pull request has been integrated
3 participants