JDK-8288368: simplify code in ValueTaglet, remove redundant code

[jonathan-gibbons]

Please review an almost trivial cleanup change, to eliminate the call to an ill-considered method in Utils, and then remove the method itself.

Verified that there is no significant change in the generated docs as a result off the change. (Just changes in timestamp/version info).

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8288368: simplify code in ValueTaglet, remove redundant code

Reviewers

• Pavel Rappo (@pavelrappo - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9149/head:pull/9149
$ git checkout pull/9149

Update a local copy of the PR:
$ git checkout pull/9149
$ git pull https://git.openjdk.org/jdk pull/9149/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9149

View PR using the GUI difftool:
$ git pr show -t 9149

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9149.diff

[bridgekeeper]

👋 Welcome back jjg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jonathan-gibbons The following label will be automatically applied to this pull request:

• javadoc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (5dcf3919)
• 00: Full (2d9b8ed1)

[pavelrappo]

I assume that all jdk.javadoc tests still pass and the JDK API Documentation still builds, right?

[openjdk]

@jonathan-gibbons This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8288368: simplify code in ValueTaglet, remove redundant code

Reviewed-by: prappo

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 451 new commits pushed to the master branch:

• f5a7de8: 8290379: Parse error with parenthesized pattern and guard using an array
• 612d8c6: 8290456: remove os::print_statistics()
• d7f0de2: 8290460: Alpine: disable some panama tests that rely on std::thread
• dfbc691: 8289524: Add JFR JIT restart event
• 4e6cd67: 8290000: Bump macOS GitHub actions to macOS 11
• af86cd3: 8290463: Fix several comment typos in sun.security.ec
• 6cd1c0c: Merge
• 2677dd6: 8289954: C2: Assert failed in PhaseCFG::verify() after JDK-8183390
• 4f3f74c: 8289127: Apache Lucene triggers: DEBUG MESSAGE: duplicated predicate failed which is impossible
• 4a4d8ed: 8289801: [IR Framework] Add flags to whitelist which can be used to simulate a specific machine setup like UseAVX
• ... and 441 more: https://git.openjdk.org/jdk/compare/a9c2ab67c44872ce0247aef6bf972bf4246b44be...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[jonathan-gibbons]

/integrate

[openjdk]

Going to push as commit 4c1cd66.
Since your change was applied there have been 511 commits pushed to the master branch:

• 6346c33: 8290826: validate-source failures after JDK-8290016
• 604a115: 8290016: IGV: Fix graph panning when mouse dragged outside of window
• 59e495e: 8290704: x86: TemplateTable::_new should not call eden_allocate() without contiguous allocs enabled
• 799a2c8: 8276561: URL$DefaultFactory::PREFIX should be static final
• 52cc6cd: 8288723: Avoid redundant ConcurrentHashMap.get call in java.time
• 3582fd9: 8290359: Ensure that all directory streams are closed in jdk.link
• 53fc495: 8290316: Ensure that all directory streams are closed in java.base
• db1e44c: 8290353: ModuleReader::list specification should suggest closing the returned stream
• 2c73a1f: 8290324: Move atomic operations outside of os_xxx.hpp
• e8975be: 8290746: ProblemList compiler/vectorization/TestAutoVecIntMinMax.java
• ... and 501 more: https://git.openjdk.org/jdk/compare/a9c2ab67c44872ce0247aef6bf972bf4246b44be...master

Your commit was automatically rebased without conflicts.

[openjdk]

@jonathan-gibbons Pushed as commit 4c1cd66.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.