New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8288499: Restore cancel-in-progress in GHA #9170
Conversation
👋 Welcome back ihse! A progress list of the required criteria for merging this PR into |
@magicus This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops. Looks good.
/integrate |
I accidentally changed the behavior in GHA wrt multiple runs from the same branch. The old solution used
cancel-in-progress: true
which means that an old batch was cancelled when a new commit was pushed to the branch.I think this is a good behavior, since it minimizes wait times for GHA results, and wastes less GHA resources.
I changed this to
false
while developing the new GHA framework, and intended to change it back before pushing, but forgot about it.Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9170/head:pull/9170
$ git checkout pull/9170
Update a local copy of the PR:
$ git checkout pull/9170
$ git pull https://git.openjdk.org/jdk pull/9170/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 9170
View PR using the GUI difftool:
$ git pr show -t 9170
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9170.diff