Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8288530: ProblemList serviceability/jvmti/VMObjectAlloc/VMObjectAllocTest.java in -Xcomp mode #9173

Closed
wants to merge 1 commit into from

Conversation

dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented Jun 15, 2022

A trivial fix to ProblemList serviceability/jvmti/VMObjectAlloc/VMObjectAllocTest.java in -Xcomp mode.

Humor note: The product bug ID and ProblemList bug ID differ by exactly 100.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8288530: ProblemList serviceability/jvmti/VMObjectAlloc/VMObjectAllocTest.java in -Xcomp mode

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9173/head:pull/9173
$ git checkout pull/9173

Update a local copy of the PR:
$ git checkout pull/9173
$ git pull https://git.openjdk.org/jdk pull/9173/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9173

View PR using the GUI difftool:
$ git pr show -t 9173

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9173.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 15, 2022

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@dcubed-ojdk
Copy link
Member Author

/label add hotspot-runtime
/label add serviceability

@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review June 15, 2022 20:20
@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Jun 15, 2022
@openjdk
Copy link

openjdk bot commented Jun 15, 2022

@dcubed-ojdk
The hotspot-runtime label was successfully added.

@openjdk openjdk bot added rfr Pull request is ready for review serviceability serviceability-dev@openjdk.org labels Jun 15, 2022
@openjdk
Copy link

openjdk bot commented Jun 15, 2022

@dcubed-ojdk
The serviceability label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Jun 15, 2022

Webrevs

@alexmenkov
Copy link

I agree the fix is trivial

@openjdk
Copy link

openjdk bot commented Jun 15, 2022

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8288530: ProblemList serviceability/jvmti/VMObjectAlloc/VMObjectAllocTest.java in -Xcomp mode

Reviewed-by: amenkov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 1855e9d: 8220732: setSeed(long) java api doc is missing warning about provided seed quality

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 15, 2022
@dcubed-ojdk
Copy link
Member Author

@alexmenkov - Thanks for the review!

/integrate

@openjdk
Copy link

openjdk bot commented Jun 15, 2022

Going to push as commit 9ff4034.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 1855e9d: 8220732: setSeed(long) java api doc is missing warning about provided seed quality

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 15, 2022
@openjdk openjdk bot closed this Jun 15, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 15, 2022
@openjdk
Copy link

openjdk bot commented Jun 15, 2022

@dcubed-ojdk Pushed as commit 9ff4034.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dcubed-ojdk dcubed-ojdk deleted the JDK-8288530 branch June 15, 2022 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org
2 participants