New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8288281: compiler/vectorapi/VectorFPtoIntCastTest.java failed with "IRViolationException: There were one or multiple IR rule failures." #9177
Conversation
…RViolationException: There were one or multiple IR rule failures."
👋 Welcome back sviswanathan! A progress list of the required criteria for merging this PR into |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and trivial.
@sviswa7 This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 16 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise, looks good!
@@ -84,7 +84,7 @@ public VectorFPtoIntCastTest() { | |||
} | |||
|
|||
@Test | |||
@IR(counts = {"F2X", ">= 1"}) | |||
@IR(counts = {"VectorCastF2X", "> 0"}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can directly use IRNode.VECTOR_CAST_F2X
(and IRNode.VECTOR_CAST_D2X
below) which makes it clearer that this is an actual IR node and not a custom string.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chhagedorn I made the change accordingly.
/integrate |
Going to push as commit 9d4b25e.
Your commit was automatically rebased without conflicts. |
The IR Framework test was failing due to incorrect node name.
Corrected the IR node name check.
Please review.
Best Regards,
Sandhya
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9177/head:pull/9177
$ git checkout pull/9177
Update a local copy of the PR:
$ git checkout pull/9177
$ git pull https://git.openjdk.org/jdk pull/9177/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 9177
View PR using the GUI difftool:
$ git pr show -t 9177
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9177.diff