8288663: JFR: Disabling the JfrThreadSampler commits only a partially disabled state

[mgronlun]

Greetings,

please review the following change set.

The problematic situation is described in the JIRA issue.

In addition, I have taken the opportunity to align "interval" with "period", since the concept is exported and used more pervasively.

Testing: jdk_jfr

Thanks
Markus

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8288663: JFR: Disabling the JfrThreadSampler commits only a partially disabled state

Reviewers

• Jaroslav Bachorik (@jbachorik - Reviewer) ⚠️ Review applies to 879c409f
• Erik Gahlin (@egahlin - Reviewer) ⚠️ Review applies to 879c409f

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9199/head:pull/9199
$ git checkout pull/9199

Update a local copy of the PR:
$ git checkout pull/9199
$ git pull https://git.openjdk.org/jdk pull/9199/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9199

View PR using the GUI difftool:
$ git pr show -t 9199

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9199.diff

[bridgekeeper]

👋 Welcome back mgronlun! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@mgronlun The following label will be automatically applied to this pull request:

• hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (400bfa50)
• 00: Full (879c409f)

[openjdk]

@mgronlun This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8288663: JFR: Disabling the JfrThreadSampler commits only a partially disabled state

Reviewed-by: jbachorik, egahlin

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 50 new commits pushed to the master branch:

• 406cf61: 8287771: Remove useless G1 After GC summary refinement and sampling thread times
• 5cdb4b1: 8288011: StringConcatFactory: Split application of stringifiers
• 46d5b68: 8288685: JFR: Use static methods for Active Recording and Active Setting events
• 68bff04: 8288673: Reduce runtime of java.time microbenchmarks
• d917e18: 8288667: Reduce runtime of java.text microbenchmarks
• 695d865: 8284672: Collapse identical catch branches in java.desktop
• 7acdcc1: 8288329: Avoid redundant TreeMap.containsKey call in PolicyParser.read
• f62b2bd: 8288480: IGV: toolbar action is not applied to the focused graph
• 02da5f9: 8263384: IGV: Outline should highlight the Graph that has focus
• 7d4df6a: 8284404: Too aggressive sweeping with Loom
• ... and 40 more: https://git.openjdk.org/jdk/compare/68b2057205844228562f3a0801d70e4a5a04ea85...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mgronlun]

Thank you @jbachorik for reviewing.

[mgronlun]

Thanks @egahlin for reviewing.

[mgronlun]

/integrate

[openjdk]

Going to push as commit a7df5a4.
Since your change was applied there have been 50 commits pushed to the master branch:

• 406cf61: 8287771: Remove useless G1 After GC summary refinement and sampling thread times
• 5cdb4b1: 8288011: StringConcatFactory: Split application of stringifiers
• 46d5b68: 8288685: JFR: Use static methods for Active Recording and Active Setting events
• 68bff04: 8288673: Reduce runtime of java.time microbenchmarks
• d917e18: 8288667: Reduce runtime of java.text microbenchmarks
• 695d865: 8284672: Collapse identical catch branches in java.desktop
• 7acdcc1: 8288329: Avoid redundant TreeMap.containsKey call in PolicyParser.read
• f62b2bd: 8288480: IGV: toolbar action is not applied to the focused graph
• 02da5f9: 8263384: IGV: Outline should highlight the Graph that has focus
• 7d4df6a: 8284404: Too aggressive sweeping with Loom
• ... and 40 more: https://git.openjdk.org/jdk/compare/68b2057205844228562f3a0801d70e4a5a04ea85...master

Your commit was automatically rebased without conflicts.

[openjdk]

@mgronlun Pushed as commit a7df5a4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[mgronlun]

/backport jdk19

[openjdk]

@mgronlun Unknown command backport - for a list of valid commands use /help.

[mgronlun]

/help

[openjdk]

@mgronlun Available commands:

• covered - used when employer has signed the OCA
• help - shows this text
• signed - used after signing the OCA
• test - used to run tests