Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8289044: ARM32: missing LIR_Assembler::cmove metadata type support #9258

Closed
wants to merge 1 commit into from

Conversation

bulasevich
Copy link
Contributor

@bulasevich bulasevich commented Jun 23, 2022

Fixing ARM32 jtreg fails:

  • compiler/floatingpoint/TestFloatJNIArgs.java
  • runtime/logging/MonitorMismatchTest.java.MonitorMismatchTest
# A fatal error has been detected by the Java Runtime Environment:
#
# Internal Error (c1_LIRAssembler_arm.cpp:1482), pid=21156, tid=21171
# Error: ShouldNotReachHere() 

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8289044: ARM32: missing LIR_Assembler::cmove metadata type support

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9258/head:pull/9258
$ git checkout pull/9258

Update a local copy of the PR:
$ git checkout pull/9258
$ git pull https://git.openjdk.org/jdk pull/9258/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9258

View PR using the GUI difftool:
$ git pr show -t 9258

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9258.diff

Sorry, something went wrong.

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 23, 2022

👋 Welcome back bulasevich! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 23, 2022
@openjdk
Copy link

openjdk bot commented Jun 23, 2022

@bulasevich The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Jun 23, 2022
@mlbridge
Copy link

mlbridge bot commented Jun 23, 2022

Webrevs

Copy link
Member

@shipilev shipilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. But since the triggering change (JDK-8288303) was delivered in JDK 19, this PR should be against JDK 19.

@bulasevich
Copy link
Contributor Author

bulasevich commented Jun 24, 2022

Looks fine. But since the triggering change (JDK-8288303) was delivered in JDK 19, this PR should be against JDK 19.

You are right. Will the change be automatically pushed to the openjdk/jdk repo? Should I close this PR?

Here is the PR against JDK 19:
openjdk/jdk19#67

@shipilev
Copy link
Member

You are right. Will the change be automatically pushed to the openjdk/jdk repo? Should I close this PR?

Yes and yes.

@bulasevich bulasevich closed this Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

None yet

2 participants