Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8288609: Update --release 19 symbol information for JDK 19 build 28 #9270

Closed
wants to merge 1 commit into from

Conversation

jddarcy
Copy link
Member

@jddarcy jddarcy commented Jun 24, 2022

Update symbol information in JDK 20 for the latest JDK 19 build.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8288609: Update --release 19 symbol information for JDK 19 build 28

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9270/head:pull/9270
$ git checkout pull/9270

Update a local copy of the PR:
$ git checkout pull/9270
$ git pull https://git.openjdk.org/jdk pull/9270/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9270

View PR using the GUI difftool:
$ git pr show -t 9270

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9270.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 24, 2022

👋 Welcome back darcy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 24, 2022
@openjdk
Copy link

openjdk bot commented Jun 24, 2022

@jddarcy The following label will be automatically applied to this pull request:

  • compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the compiler compiler-dev@openjdk.org label Jun 24, 2022
@mlbridge
Copy link

mlbridge bot commented Jun 24, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Jun 24, 2022

@jddarcy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8288609: Update --release 19 symbol information for JDK 19 build 28

Reviewed-by: iris

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 9dc9a64: 8287281: adjust guarantee in Handshake::execute for the case of target thread being current
  • 64782a7: 8288623: Move Continuation classes out of javaClasses.hpp

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 24, 2022
@jddarcy
Copy link
Member Author

jddarcy commented Jun 24, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Jun 24, 2022

Going to push as commit 9918b6d.
Since your change was applied there have been 8 commits pushed to the master branch:

  • f67c536: 8288935: Remove excessive includes introduced in loom
  • 239b4bb: 8289095: (fs) UnixCopyFile build error on linux-x86
  • 0d2952e: 8289129: [BACKOUT] JDK-8287281 adjust guarantee in Handshake::execute for the case of target thread being current
  • fdc8455: 8288495: [test] Make OutputAnalyzer exception more informative
  • 925084c: 8288976: classfile parser 'wrong name' error message has the names the wrong way around
  • 17aacde: 8288669: compiler/vectorapi/VectorFPtoIntCastTest.java still fails with "IRViolationException: There were one or multiple IR rule failures."
  • 9dc9a64: 8287281: adjust guarantee in Handshake::execute for the case of target thread being current
  • 64782a7: 8288623: Move Continuation classes out of javaClasses.hpp

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 24, 2022
@openjdk openjdk bot closed this Jun 24, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 24, 2022
@openjdk
Copy link

openjdk bot commented Jun 24, 2022

@jddarcy Pushed as commit 9918b6d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler compiler-dev@openjdk.org integrated Pull request has been integrated
2 participants