Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8289258: ProblemList some failing custom loader tests with ZGC #9301

Conversation

calvinccheung
Copy link
Member

@calvinccheung calvinccheung commented Jun 28, 2022

Problem listing the following tests in ProblemList-zgc.txt since they only failed with ZGC. See JDK-8289257 for details.

  • runtime/cds/appcds/customLoader/HelloCustom.java
  • runtime/cds/appcds/customLoader/HelloCustom_JFR.java
  • runtime/cds/appcds/dynamicArchive/HelloDynamicCustomUnload.java

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8289258: ProblemList some failing custom loader tests with ZGC

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9301/head:pull/9301
$ git checkout pull/9301

Update a local copy of the PR:
$ git checkout pull/9301
$ git pull https://git.openjdk.org/jdk pull/9301/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9301

View PR using the GUI difftool:
$ git pr show -t 9301

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9301.diff

@calvinccheung
Copy link
Member Author

/label add hotspot-runtime

@calvinccheung calvinccheung marked this pull request as ready for review June 28, 2022 05:13
@bridgekeeper
Copy link

bridgekeeper bot commented Jun 28, 2022

👋 Welcome back ccheung! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 28, 2022
Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks.

@openjdk
Copy link

openjdk bot commented Jun 28, 2022

@calvinccheung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8289258: ProblemList some failing custom loader tests with ZGC

Reviewed-by: dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated hotspot-runtime hotspot-runtime-dev@openjdk.org labels Jun 28, 2022
@openjdk
Copy link

openjdk bot commented Jun 28, 2022

@calvinccheung
The hotspot-runtime label was successfully added.

@calvinccheung
Copy link
Member Author

Thanks @dholmes-ora.

/integrate auto

@openjdk openjdk bot added the auto label Jun 28, 2022
@openjdk
Copy link

openjdk bot commented Jun 28, 2022

@calvinccheung This pull request will be automatically integrated when it is ready

@openjdk
Copy link

openjdk bot commented Jun 28, 2022

/integrate

1 similar comment
@openjdk
Copy link

openjdk bot commented Jun 28, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Jun 28, 2022

Going to push as commit 3336971.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 28, 2022
@openjdk openjdk bot closed this Jun 28, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 28, 2022
@openjdk
Copy link

openjdk bot commented Jun 28, 2022

@openjdk[bot] Pushed as commit 3336971.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mlbridge
Copy link

mlbridge bot commented Jun 28, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Jun 28, 2022

@openjdk[bot] The command integrate can only be used in open pull requests.

@openjdk
Copy link

openjdk bot commented Jun 28, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Jun 28, 2022

@openjdk[bot] The command integrate can only be used in open pull requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
2 participants