Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8289440: Remove vmTestbase/nsk/monitoring/MemoryPoolMBean/isCollectionUsageThresholdExceeded/isexceeded003 from ProblemList.txt #9325

Conversation

kevinjwalls
Copy link
Contributor

@kevinjwalls kevinjwalls commented Jun 29, 2022

More context in the bug, but there's no evidence that this test should still be problemlisted.

Adding enableVerbose in the test itself should still keep this trivial: seeing what actually happened in a test that was once labelled as failing is really important!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8289440: Remove vmTestbase/nsk/monitoring/MemoryPoolMBean/isCollectionUsageThresholdExceeded/isexceeded003 from ProblemList.txt

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9325/head:pull/9325
$ git checkout pull/9325

Update a local copy of the PR:
$ git checkout pull/9325
$ git pull https://git.openjdk.org/jdk pull/9325/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9325

View PR using the GUI difftool:
$ git pr show -t 9325

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9325.diff

…nUsageThresholdExceeded/isexceeded003 from ProblemList.txt
@bridgekeeper
Copy link

bridgekeeper bot commented Jun 29, 2022

👋 Welcome back kevinw! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 29, 2022
@openjdk
Copy link

openjdk bot commented Jun 29, 2022

@kevinjwalls The following label will be automatically applied to this pull request:

  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the serviceability serviceability-dev@openjdk.org label Jun 29, 2022
@mlbridge
Copy link

mlbridge bot commented Jun 29, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Jun 29, 2022

@kevinjwalls This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8289440: Remove vmTestbase/nsk/monitoring/MemoryPoolMBean/isCollectionUsageThresholdExceeded/isexceeded003 from ProblemList.txt

Reviewed-by: amenkov, lmesnik

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 40 new commits pushed to the master branch:

  • feb223a: 8288707: javax/swing/JToolBar/4529206/bug4529206.java: setFloating does not work correctly
  • c3addbb: 8288895: LdapContext doesn't honor set referrals limit
  • 1305fb5: 8287984: AArch64: [vector] Make all bits set vector sharable for match rules
  • 7b5bd25: 8286397: Address possibly lossy conversions in jdk.hotspot.agent
  • 28c5e48: 8287094: IGV: show node input numbers in edge tooltips
  • da6d1fc: 8289477: Memory corruption with CPU_ALLOC, CPU_FREE on muslc
  • 31e50f2: 8286104: use aggressive liveness for unstable_if traps
  • dddd4e7: 8289291: HttpServer sets incorrect value for "max" parameter in Keep-Alive header value
  • 048bffa: Merge
  • cf71544: 8289252: Recommend Locale.of() method instead of the constructor
  • ... and 30 more: https://git.openjdk.org/jdk/compare/af0088076dd8cb5d5bc47c59838e7f5ef4f6d8a9...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 29, 2022
@kevinjwalls
Copy link
Contributor Author

Thanks Alex!

@kevinjwalls
Copy link
Contributor Author

Thanks Leonid!

@kevinjwalls
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 30, 2022

Going to push as commit 00d06d4.
Since your change was applied there have been 40 commits pushed to the master branch:

  • feb223a: 8288707: javax/swing/JToolBar/4529206/bug4529206.java: setFloating does not work correctly
  • c3addbb: 8288895: LdapContext doesn't honor set referrals limit
  • 1305fb5: 8287984: AArch64: [vector] Make all bits set vector sharable for match rules
  • 7b5bd25: 8286397: Address possibly lossy conversions in jdk.hotspot.agent
  • 28c5e48: 8287094: IGV: show node input numbers in edge tooltips
  • da6d1fc: 8289477: Memory corruption with CPU_ALLOC, CPU_FREE on muslc
  • 31e50f2: 8286104: use aggressive liveness for unstable_if traps
  • dddd4e7: 8289291: HttpServer sets incorrect value for "max" parameter in Keep-Alive header value
  • 048bffa: Merge
  • cf71544: 8289252: Recommend Locale.of() method instead of the constructor
  • ... and 30 more: https://git.openjdk.org/jdk/compare/af0088076dd8cb5d5bc47c59838e7f5ef4f6d8a9...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 30, 2022
@openjdk openjdk bot closed this Jun 30, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 30, 2022
@openjdk
Copy link

openjdk bot commented Jun 30, 2022

@kevinjwalls Pushed as commit 00d06d4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org
3 participants