Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8288882: JFileChooser - empty (0 bytes) file is displayed as 1 KB #9327

Closed
wants to merge 31 commits into from
Closed

8288882: JFileChooser - empty (0 bytes) file is displayed as 1 KB #9327

Changes from 1 commit
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
c958313
JFileChooser empty file size 0 bytes fixed
kumarabhi006 Jun 29, 2022
a7b31d9
Merge branch 'master' of https://git.openjdk.java.net/jdk into JDK-82…
kumarabhi006 Jul 6, 2022
b1006c6
Byte entry added to basic.properties, MessageFormat used to format fi…
kumarabhi006 Jul 6, 2022
8f6c9fe
alignment, newline and bytes handling fix
kumarabhi006 Jul 13, 2022
518c6fd
Handling of plural forms using choiceFormat
kumarabhi006 Jul 14, 2022
6b3ae9e
properties file reverted back and filesize shown in KB
kumarabhi006 Jul 15, 2022
f29fe0b
File Size shows upto 1 decimal value
kumarabhi006 Jul 20, 2022
600ac73
manual test case moved to directory and multiple file size check added
kumarabhi006 Jul 21, 2022
31e9252
whitespace removed from FileSizeCheck file
kumarabhi006 Jul 21, 2022
0ccb752
added os.family tag and updated summary tag
kumarabhi006 Jul 21, 2022
02d4c08
Deleted ZeroFileSizeCheck file and updated text from 999.0 to 999 in …
kumarabhi006 Jul 21, 2022
99778d9
declare variable for 1000.0 and method formatToDoubleValue moved insi…
kumarabhi006 Jul 22, 2022
4dbd584
space added as per review comment
kumarabhi006 Jul 27, 2022
084a82a
creating and deleting test files dynamically
kumarabhi006 Jul 28, 2022
45d017e
suggested review comments updated
kumarabhi006 Aug 9, 2022
e699f03
updated as per review comments
kumarabhi006 Aug 10, 2022
1d830a5
Smaller file sizes display one decimal precision
kumarabhi006 Aug 11, 2022
a5ae29c
Updated as per suggested changes
kumarabhi006 Aug 12, 2022
d749cc3
Updated as per review comments
kumarabhi006 Aug 12, 2022
8ac2785
comment added
kumarabhi006 Aug 17, 2022
497c686
whitespace error removed
kumarabhi006 Aug 17, 2022
5526919
Updated as per review comment
kumarabhi006 Aug 19, 2022
dac1ae7
Updated as per review comments
kumarabhi006 Aug 24, 2022
1e086ca
Comments modified and formatToDoubleValue method name renamed
kumarabhi006 Aug 25, 2022
8ffcc83
Updated as per suggested changes
kumarabhi006 Aug 26, 2022
cea398f
Filesize calculation logic modified
kumarabhi006 Sep 2, 2022
99224c1
Review comments fix
kumarabhi006 Sep 9, 2022
3d6ae26
Review comment fix
kumarabhi006 Sep 13, 2022
6d2b955
Review comment fix
kumarabhi006 Sep 18, 2022
b4361c3
modifiers order changed as per review comment
kumarabhi006 Sep 28, 2022
604d6fd
Review comment fix
kumarabhi006 Sep 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
18 changes: 9 additions & 9 deletions test/jdk/javax/swing/JFileChooser/FileSizeCheck.java
View file
Open in desktop
Expand Up @@ -48,15 +48,15 @@ public class FileSizeCheck {
private static final String INSTRUCTIONS =
"Click on the \"Details\" button in right-top corner.\n\n" +
"Scroll Down if required. \n\n" +
"Test 1: If the size of 1-Empty-File shows 0.0 KB\n" +
"Test 2: If the size of 2-File-1-Byte shows 0.1 KB\n" +
"Test 3: If the size of 3-File-500-Byte shows 0.5 KB\n" +
"Test 4: If the size of 4-File-1000-Byte shows 1.0 KB\n" +
"Test 5: If the size of 5-File-2047-Byte shows 2.0 KB\n" +
"Test 6: If the size of 6-File-2.5-KB shows 2.5 KB\n" +
"Test 7: If the size of 7-File-999-KB shows 999.0 KB\n" +
"Test 8: If the size of 8-File-1000-KB shows 1.0 MB\n" +
"Test 9: If the size of 9-File-2.8-MB shows 2.8 MB\n\n" +
"Test 1: If the size of 1st-Empty-File shows 0.0 KB\n" +
"Test 2: If the size of 2nd-File-1-Byte shows 0.1 KB\n" +
"Test 3: If the size of 3rd-File-500-Byte shows 0.5 KB\n" +
"Test 4: If the size of 4th-File-1000-Byte shows 1.0 KB\n" +
"Test 5: If the size of 5th-File-2047-Byte shows 2.0 KB\n" +
"Test 6: If the size of 6th-File-2.5-KB shows 2.5 KB\n" +
"Test 7: If the size of 7th-File-999-KB shows 999.0 KB\n" +
"Test 8: If the size of 8th-File-1000-KB shows 1.0 MB\n" +
"Test 9: If the size of 9th-File-2.8-MB shows 2.8 MB\n\n" +
"press PASS.\n\n";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to have 1st-Empty-File, 2nd-File-1-Byte etc but it's upto you..

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated the suggested changes.


public static void test() {
Expand Down