8289520: G1: Remove duplicate checks in G1BarrierSetC1::post_barrier

[albertnetymk]

Simple change of removing effectively dead code.

Test: tier1-3

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8289520: G1: Remove duplicate checks in G1BarrierSetC1::post_barrier

Reviewers

• Thomas Schatzl (@tschatzl - Reviewer)
• Ivan Walulya (@walulyai - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9333/head:pull/9333
$ git checkout pull/9333

Update a local copy of the PR:
$ git checkout pull/9333
$ git pull https://git.openjdk.org/jdk pull/9333/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9333

View PR using the GUI difftool:
$ git pr show -t 9333

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9333.diff

[bridgekeeper]

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@albertnetymk The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (f2927a2d)

[tschatzl]

Lgtm.

[openjdk]

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8289520: G1: Remove duplicate checks in G1BarrierSetC1::post_barrier

Reviewed-by: tschatzl, iwalulya

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 29 new commits pushed to the master branch:

• e31003a: 8289575: G1: Remove unnecessary is-marking-active check in G1BarrierSetRuntime::write_ref_field_pre_entry
• 8e7a3cb: 8289431: (zipfs) Avoid redundant HashMap.get in ZipFileSystemProvider.removeFileSystem
• 649f2d8: 8065097: [macosx] javax/swing/Popup/TaskbarPositionTest.java fails because Popup is one pixel off
• d8444aa: 8286610: Add additional diagnostic output to java/net/DatagramSocket/InterruptibleDatagramSocket.java
• 70f5693: Merge
• f5cdaba: 8245268: -Xcomp is missing from java launcher documentation
• 9515560: 8288703: GetThreadState returns 0 for virtual thread that has terminated
• cfc9a88: 8288854: getLocalGraphicsEnvironment() on for multi-screen setups throws exception NPE
• 9925014: 8280320: C2: Loop opts are missing during OSR compilation
• 8e01ffb: 8289570: SegmentAllocator:allocateUtf8String(String str) default behavior mismatch to spec
• ... and 19 more: https://git.openjdk.org/jdk/compare/c3addbb1c01483e10189cc46d8f2378e5b56dcee...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[albertnetymk]

Thanks for the review.

/integrate

[openjdk]

Going to push as commit 4c997ba.
Since your change was applied there have been 37 commits pushed to the master branch:

• 1b997db: 8289427: compiler/compilercontrol/jcmd/ClearDirectivesFileStackTest.java failed with null setting
• 688712f: 8289633: Forbid raw C-heap allocation functions in hotspot and fix findings
• df063f7: 8289484: Cleanup unnecessary null comparison before instanceof check in java.rmi
• 9ccae70: 8287593: ShortResponseBody could be made more resilient to rogue connections
• bad9ffe: 8288947: G1: Consolidate per-region is-humongous query in G1CollectedHeap
• b5d9656: 8288971: AArch64: Clean up stack and register handling in interpreter
• d53b02e: 8287312: G1: Early return on first failure in VerifyRegionClosure
• a8edd7a: 8289569: [test] java/lang/ProcessBuilder/Basic.java fails on Alpine/musl
• e31003a: 8289575: G1: Remove unnecessary is-marking-active check in G1BarrierSetRuntime::write_ref_field_pre_entry
• 8e7a3cb: 8289431: (zipfs) Avoid redundant HashMap.get in ZipFileSystemProvider.removeFileSystem
• ... and 27 more: https://git.openjdk.org/jdk/compare/c3addbb1c01483e10189cc46d8f2378e5b56dcee...master

Your commit was automatically rebased without conflicts.

[openjdk]

@albertnetymk Pushed as commit 4c997ba.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.