8289575: G1: Remove unnecessary is-marking-active check in G1BarrierSetRuntime::write_ref_field_pre_entry

[albertnetymk]

Simple change of removing an unnecessary check. After that, the enqueue method becomes unused so removed as well.

Test: tier1-3

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8289575: G1: Remove unnecessary is-marking-active check in G1BarrierSetRuntime::write_ref_field_pre_entry

Reviewers

• Thomas Schatzl (@tschatzl - Reviewer)
• Ivan Walulya (@walulyai - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9345/head:pull/9345
$ git checkout pull/9345

Update a local copy of the PR:
$ git checkout pull/9345
$ git pull https://git.openjdk.org/jdk pull/9345/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9345

View PR using the GUI difftool:
$ git pr show -t 9345

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9345.diff

[bridgekeeper]

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@albertnetymk The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (0ac26f4b)

[tschatzl]

Lgtm. I closed JDK-8258607 as duplicate of this as this change removes the last use of SATBMarkQueue::enqueue.

[openjdk]

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8289575: G1: Remove unnecessary is-marking-active check in G1BarrierSetRuntime::write_ref_field_pre_entry

Reviewed-by: tschatzl, iwalulya

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

• f190f4e: 8288444: Remove the workaround for frame.pack() in ModalDialogTest
• d260a4e: 8289434: x86_64: Improve comment on gen_continuation_enter()
• 124c63c: 8288294: [vector] Add Identity/Ideal transformations for vector logic operations
• 918068a: Merge
• c20b3aa: 8289278: Suspend/ResumeAllVirtualThreads need both can_suspend and can_support_virtual_threads

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[albertnetymk]

Thanks for the review.

/integrate

[openjdk]

Going to push as commit e31003a.
Since your change was applied there have been 26 commits pushed to the master branch:

• 8e7a3cb: 8289431: (zipfs) Avoid redundant HashMap.get in ZipFileSystemProvider.removeFileSystem
• 649f2d8: 8065097: [macosx] javax/swing/Popup/TaskbarPositionTest.java fails because Popup is one pixel off
• d8444aa: 8286610: Add additional diagnostic output to java/net/DatagramSocket/InterruptibleDatagramSocket.java
• 70f5693: Merge
• f5cdaba: 8245268: -Xcomp is missing from java launcher documentation
• 9515560: 8288703: GetThreadState returns 0 for virtual thread that has terminated
• cfc9a88: 8288854: getLocalGraphicsEnvironment() on for multi-screen setups throws exception NPE
• 9925014: 8280320: C2: Loop opts are missing during OSR compilation
• 8e01ffb: 8289570: SegmentAllocator:allocateUtf8String(String str) default behavior mismatch to spec
• 20124ac: 8289585: ProblemList sun/tools/jhsdb/JStackStressTest.java on linux-aarch64
• ... and 16 more: https://git.openjdk.org/jdk/compare/00d06d4a82c5cbc8cc5fde97caa8cb56279c441a...master

Your commit was automatically rebased without conflicts.

[openjdk]

@albertnetymk Pushed as commit e31003a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.