New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JDK-8289569: [test] java/lang/ProcessBuilder/Basic.java fails on Alpine/musl #9361
Conversation
👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me.
Actually, since this is a test fix, I'd prefer if you could do it directly in jdk19. We see the failures in our Alpine testing there, too. |
@MBaesken This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 23 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Do you want to leave the "Platform.isMusl()" parts in the code? |
I would leave it for now if it is okay. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1.
/integrate |
Going to push as commit a8edd7a.
Your commit was automatically rebased without conflicts. |
Currently the ProcessBuilder/Basic.java test fails on musl.
We run into
This seems to be a musl/Alpine specific issue with some process execs.
So adding !vm.musl to the test might make sense.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9361/head:pull/9361
$ git checkout pull/9361
Update a local copy of the PR:
$ git checkout pull/9361
$ git pull https://git.openjdk.org/jdk pull/9361/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 9361
View PR using the GUI difftool:
$ git pr show -t 9361
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9361.diff