8289729: G1: Incorrect verification logic in G1ConcurrentMark::clear_next_bitmap

[albertnetymk]

One line change of negating a condition.

Test: hotspot_gc

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8289729: G1: Incorrect verification logic in G1ConcurrentMark::clear_next_bitmap

Reviewers

• Thomas Schatzl (@tschatzl - Reviewer)
• Ivan Walulya (@walulyai - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9374/head:pull/9374
$ git checkout pull/9374

Update a local copy of the PR:
$ git checkout pull/9374
$ git pull https://git.openjdk.org/jdk pull/9374/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9374

View PR using the GUI difftool:
$ git pr show -t 9374

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9374.diff

[bridgekeeper]

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@albertnetymk The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (e2be917f)

[tschatzl]

Lgtm. Good catch.

[openjdk]

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8289729: G1: Incorrect verification logic in G1ConcurrentMark::clear_next_bitmap

Reviewed-by: tschatzl, iwalulya

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

• f783244: 8289706: (cs) Avoid redundant TreeMap.containsKey call in AbstractCharsetProvider
• fafe8b3: 8289604: compiler/vectorapi/VectorLogicalOpIdentityTest.java failed on x86 AVX1 system
• 3515604: 8280481: Duplicated stubs to interpreter for static calls
• d48694d: 8283335: Add exists and readAttributesIfExists methods to FileSystemProvider
• c45d613: 8289687: [JVMCI] bug in HotSpotResolvedJavaMethodImpl.equals
• 77c3bbf: 8289617: Remove test/jdk/java/net/ServerSocket/ThreadStop.java

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[albertnetymk]

Moved to openjdk/jdk19#113