Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8137280: Remove eager reclaim of humongous controls #9392

Closed
wants to merge 1 commit into from

Conversation

albertnetymk
Copy link
Member

@albertnetymk albertnetymk commented Jul 6, 2022

Simple change of removing two experiment flags whose default value is true.

Test: hotspot_gc


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8137280: Remove eager reclaim of humongous controls

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9392/head:pull/9392
$ git checkout pull/9392

Update a local copy of the PR:
$ git checkout pull/9392
$ git pull https://git.openjdk.org/jdk pull/9392/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9392

View PR using the GUI difftool:
$ git pr show -t 9392

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9392.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 6, 2022

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8137280 8137280: Remove eager reclaim of humongous controls Jul 6, 2022
@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 6, 2022
@openjdk
Copy link

openjdk bot commented Jul 6, 2022

@albertnetymk The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Jul 6, 2022
@mlbridge
Copy link

mlbridge bot commented Jul 6, 2022

Webrevs

Copy link
Contributor

@tschatzl tschatzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@openjdk
Copy link

openjdk bot commented Jul 6, 2022

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8137280: Remove eager reclaim of humongous controls

Reviewed-by: tschatzl, iwalulya

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

  • 9f37ba4: 8288706: Unused parameter 'boolean newln' in method java.lang.VersionProps#print(boolean, boolean)
  • dfb24ae: 8289060: Undefined Behaviour in class VMReg
  • 82a8bd7: 8287596: Reorg jdk.test.lib.util.ForceGC
  • cc2b792: 8288992: AArch64: CMN should be handled the same way as CMP
  • 75c0a5b: 8288824: [arm32] Display isetstate in register output
  • 83a5d59: 8278479: RunThese test failure with +UseHeavyMonitors and +VerifyHeavyMonitors
  • cbaf6e8: 8288022: c2: Transform (CastLL (AddL into (AddL (CastLL when possible
  • 8341895: 8289739: Add G1 specific GC breakpoints for testing
  • ac6be16: 8289695: [TESTBUG] TestMemoryAwareness.java fails on cgroups v2 and crun
  • 4ad18cf: 8289730: Deprecated code sample in java.lang.ClassCastException
  • ... and 7 more: https://git.openjdk.org/jdk/compare/a5934cddca9b962d8e1b709de23c169904b95525...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 6, 2022
@albertnetymk
Copy link
Member Author

Thanks for the review.

/integrate

@openjdk
Copy link

openjdk bot commented Jul 7, 2022

Going to push as commit 013a5ee.
Since your change was applied there have been 39 commits pushed to the master branch:

  • 77ad998: 8289778: ZGC: incorrect use of os::free() for mountpoint string handling after JDK-8289633
  • 532a6ec: 7124313: [macosx] Swing Popups should overlap taskbar
  • e05b2f2: 8289856: [PPC64] SIGSEGV in C2Compiler::init_c2_runtime() after JDK-8289060
  • cce77a7: 8289799: Build warning in methodData.cpp memset zero-length parameter
  • d1249aa: 8198668: MemoryPoolMBean/isUsageThresholdExceeded/isexceeded001/TestDescription.java still failing
  • a79ce4e: 8286941: Add mask IR for partial vector operations for ARM SVE
  • 569de45: 8289620: gtest/MetaspaceUtilsGtests.java failed with unexpected stats values
  • 403a9bc: 8289436: Make the redefine timer statistics more accurate
  • a40c17b: 8289775: Update java.lang.invoke.MethodHandle[s] to use snippets
  • 2a6ec88: Merge
  • ... and 29 more: https://git.openjdk.org/jdk/compare/a5934cddca9b962d8e1b709de23c169904b95525...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 7, 2022
@openjdk openjdk bot closed this Jul 7, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 7, 2022
@openjdk
Copy link

openjdk bot commented Jul 7, 2022

@albertnetymk Pushed as commit 013a5ee.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@albertnetymk albertnetymk deleted the g1-eager-reclaim branch July 7, 2022 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
3 participants