New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8249834: java/util/ArrayList/Bug8146568.java and j/u/Vector/Bug8148174.java use @ignore w/o bug-id #9404
Conversation
👋 Welcome back bwhuang-us! A progress list of the required criteria for merging this PR into |
@bwhuang-us The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello Bill,
The change looks fine to me.
I wasn't aware that a jdk_core_manual
test group existed. Before merging, please do run a test which exercises either jdk_core_manual
or jdk_core_manual_no_input
test group, to make sure this change works fine.
@bwhuang-us This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 102 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jaikiran) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
Thank you for running those tests, Bill. Please go ahead and issue a integrate command when you are ready and I can sponsor this for you. |
/integrate |
@bwhuang-us |
/sponsor |
Going to push as commit dbab827.
Your commit was automatically rebased without conflicts. |
@jaikiran @bwhuang-us Pushed as commit dbab827. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Tests Bug8146568 and Bug8148174 were disabled for high memory consumption, over 17G. This is a task to re-enable these two tests by marking them as manual tests.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9404/head:pull/9404
$ git checkout pull/9404
Update a local copy of the PR:
$ git checkout pull/9404
$ git pull https://git.openjdk.org/jdk pull/9404/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 9404
View PR using the GUI difftool:
$ git pr show -t 9404
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9404.diff