Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8249834: java/util/ArrayList/Bug8146568.java and j/u/Vector/Bug8148174.java use @ignore w/o bug-id #9404

Closed
wants to merge 2 commits into from

Conversation

bwhuang-us
Copy link
Contributor

@bwhuang-us bwhuang-us commented Jul 6, 2022

Tests Bug8146568 and Bug8148174 were disabled for high memory consumption, over 17G. This is a task to re-enable these two tests by marking them as manual tests.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8249834: java/util/ArrayList/Bug8146568.java and j/u/Vector/Bug8148174.java use @ignore w/o bug-id

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9404/head:pull/9404
$ git checkout pull/9404

Update a local copy of the PR:
$ git checkout pull/9404
$ git pull https://git.openjdk.org/jdk pull/9404/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9404

View PR using the GUI difftool:
$ git pr show -t 9404

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9404.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 6, 2022

👋 Welcome back bwhuang-us! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 6, 2022
@openjdk
Copy link

openjdk bot commented Jul 6, 2022

@bwhuang-us The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Jul 6, 2022
@mlbridge
Copy link

mlbridge bot commented Jul 6, 2022

Webrevs

@bwhuang-us bwhuang-us changed the title 8249834: Marked Bug8146568 and Bug8148174 as manual tests. JDK-8249834: Marked Bug8146568 and Bug8148174 as manual tests. Jul 6, 2022
@bwhuang-us bwhuang-us changed the title JDK-8249834: Marked Bug8146568 and Bug8148174 as manual tests. 8249834: java/util/ArrayList/Bug8146568.java and j/u/Vector/Bug8148174.java use @ignore w/o bug-id Jul 6, 2022
test/jdk/TEST.groups Outdated Show resolved Hide resolved
Copy link
Member

@jaikiran jaikiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Bill,
The change looks fine to me.

I wasn't aware that a jdk_core_manual test group existed. Before merging, please do run a test which exercises either jdk_core_manual or jdk_core_manual_no_input test group, to make sure this change works fine.

@openjdk
Copy link

openjdk bot commented Jul 13, 2022

@bwhuang-us This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8249834: java/util/ArrayList/Bug8146568.java and j/u/Vector/Bug8148174.java use @ignore w/o bug-id

Reviewed-by: jpai

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 102 new commits pushed to the master branch:

  • 3216d19: 8289559: java/awt/a11y/AccessibleJPopupMenuTest.java test fails with java.lang.NullPointerException
  • c83fcbd: 8290079: Reduce interaction with volatile in static initializer of BigInteger
  • 74ac5df: 8290234: [JVMCI] use JVMCIKlassHandle to protect raw Klass* values from concurrent G1 scanning
  • 5e3ecff: 8290253: gc/g1/TestVerificationInConcurrentCycle.java#id1 fails with "Error. can't find sun.hotspot.WhiteBox in test directory or libraries"
  • 5358045: 8066859: java/lang/ref/OOMEInReferenceHandler.java failed with java.lang.Exception: Reference Handler thread died
  • 2583feb: 8290023: Remove use of IgnoreUnrecognizedVMOptions in gc tests
  • 44fb92e: 8290197: test/jdk/java/nio/file/Files/probeContentType/Basic.java fails on some systems for the ".rar" extension
  • f528124: 8289284: jdk.tracePinnedThreads output confusing when pinned due to native frame
  • 572c14e: 8288624: Cleanup CommentHelper.getText0
  • 6e18883: 8290162: Reset recursion counter missed in fix of JDK-8224267
  • ... and 92 more: https://git.openjdk.org/jdk/compare/2a6ec88cd09adec43df3da1b22653271517b14a8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jaikiran) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 13, 2022
@bwhuang-us
Copy link
Contributor Author

bwhuang-us commented Jul 13, 2022

Test group jdk_core_manual_no_input was run with no issues. The two newly added tests were run and passed.

Screen Shot 2022-07-13 at 11 21 56 AM

@jaikiran
Copy link
Member

Thank you for running those tests, Bill. Please go ahead and issue a integrate command when you are ready and I can sponsor this for you.

@bwhuang-us
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jul 14, 2022
@openjdk
Copy link

openjdk bot commented Jul 14, 2022

@bwhuang-us
Your change (at version fc2d6bb) is now ready to be sponsored by a Committer.

@jaikiran
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Jul 14, 2022

Going to push as commit dbab827.
Since your change was applied there have been 102 commits pushed to the master branch:

  • 3216d19: 8289559: java/awt/a11y/AccessibleJPopupMenuTest.java test fails with java.lang.NullPointerException
  • c83fcbd: 8290079: Reduce interaction with volatile in static initializer of BigInteger
  • 74ac5df: 8290234: [JVMCI] use JVMCIKlassHandle to protect raw Klass* values from concurrent G1 scanning
  • 5e3ecff: 8290253: gc/g1/TestVerificationInConcurrentCycle.java#id1 fails with "Error. can't find sun.hotspot.WhiteBox in test directory or libraries"
  • 5358045: 8066859: java/lang/ref/OOMEInReferenceHandler.java failed with java.lang.Exception: Reference Handler thread died
  • 2583feb: 8290023: Remove use of IgnoreUnrecognizedVMOptions in gc tests
  • 44fb92e: 8290197: test/jdk/java/nio/file/Files/probeContentType/Basic.java fails on some systems for the ".rar" extension
  • f528124: 8289284: jdk.tracePinnedThreads output confusing when pinned due to native frame
  • 572c14e: 8288624: Cleanup CommentHelper.getText0
  • 6e18883: 8290162: Reset recursion counter missed in fix of JDK-8224267
  • ... and 92 more: https://git.openjdk.org/jdk/compare/2a6ec88cd09adec43df3da1b22653271517b14a8...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 14, 2022
@openjdk openjdk bot closed this Jul 14, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jul 14, 2022
@openjdk
Copy link

openjdk bot commented Jul 14, 2022

@jaikiran @bwhuang-us Pushed as commit dbab827.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@bwhuang-us bwhuang-us deleted the JDK-8249834 branch March 1, 2023 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
3 participants