8289137: Automatically adapt Young/OldPLABSize and when setting only MinTLABSize

[tschatzl]

Hi all,

can I get reviews for this enhancement fixing a sometimes annoying UI issue where setting -XX:MinTLABSize does not automatically update -XX:YoungPLABSize and -XX:OldPLABSize if they are not set?
This avoids some unnecessary retries.

Testing: gha, test case

Thanks,
Thomas

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8289137: Automatically adapt Young/OldPLABSize and when setting only MinTLABSize

Reviewers

• Ivan Walulya (@walulyai - Reviewer)
• Sangheon Kim (@sangheon - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9425/head:pull/9425
$ git checkout pull/9425

Update a local copy of the PR:
$ git checkout pull/9425
$ git pull https://git.openjdk.org/jdk pull/9425/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9425

View PR using the GUI difftool:
$ git pr show -t 9425

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9425.diff

[bridgekeeper]

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tschatzl The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (af272e30)
• 01: Full - Incremental (7d7382bc)
• 00: Full (e59d06d9)

[walulyai]

Lgtm!

[openjdk]

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8289137: Automatically adapt Young/OldPLABSize and when setting only MinTLABSize

Reviewed-by: iwalulya, sangheki

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 292 new commits pushed to the master branch:

• 4d796ee: 8290887: Unused private method in TrustManagerFactoryImpl
• f0f78a9: 8290894: Reduce runtime of vm.lang microbenchmarks
• 1451642: 8244976: vmTestbase/nsk/jdi/Event/request/request001.java doesn' initialize eName
• 8159a1a: 8290706: Remove the support for inline contiguous allocations
• 7318b22: 8289551: Conversions between bit representations of half precision values and floats
• 2ae8e31: 8290669: Fix wording in sun.security.ec
• 8939095: 8289996: Fix array range check hoisting for some scaled loop iv
• da9cc5c: 8290806: Only add eager reclaim task to G1 post evacuate tasks if there were candidates
• 330adc0: 8290969: DumpClassListCLDClosure incorrectly uses ResizeableResourceHashtable
• 28bbdc5: 8290972: ProblemList java/lang/ProcessBuilder/PipelineLeaksFD.java
• ... and 282 more: https://git.openjdk.org/jdk/compare/77c3bbf105403089fec69d51406fe3e6f562271f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[sangheon]

Looks good.

[tschatzl]

Thanks @walulyai @sangheon for your reviews

/integrate

[openjdk]

Going to push as commit 2a1d9cf.
Since your change was applied there have been 292 commits pushed to the master branch:

• 4d796ee: 8290887: Unused private method in TrustManagerFactoryImpl
• f0f78a9: 8290894: Reduce runtime of vm.lang microbenchmarks
• 1451642: 8244976: vmTestbase/nsk/jdi/Event/request/request001.java doesn' initialize eName
• 8159a1a: 8290706: Remove the support for inline contiguous allocations
• 7318b22: 8289551: Conversions between bit representations of half precision values and floats
• 2ae8e31: 8290669: Fix wording in sun.security.ec
• 8939095: 8289996: Fix array range check hoisting for some scaled loop iv
• da9cc5c: 8290806: Only add eager reclaim task to G1 post evacuate tasks if there were candidates
• 330adc0: 8290969: DumpClassListCLDClosure incorrectly uses ResizeableResourceHashtable
• 28bbdc5: 8290972: ProblemList java/lang/ProcessBuilder/PipelineLeaksFD.java
• ... and 282 more: https://git.openjdk.org/jdk/compare/77c3bbf105403089fec69d51406fe3e6f562271f...master

Your commit was automatically rebased without conflicts.

[openjdk]

@tschatzl Pushed as commit 2a1d9cf.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.