8290164: compiler/runtime/TestConstantsInError.java fails on riscv

[feilongjiang]

compiler/runtime/TestConstantsInError.java fails on riscv with the following error:

Execution failed: `main' threw exception: java.lang.RuntimeException: 'made not entrant' found in stdout

Similar to AArch64, RISCV64 does not patch C1 compiled code (see JDK-8223613). So we should add Platform.isRISCV64 too for the test.

This test requires vm.flagless. According to JDK-8246494, tests with vm.flagless will be excluded from runs w/ any other X / XX flags passed via -vmoption / -javaoption.
Since we added -Xmx option for all jtreg tests, so this failure does not menifest before.

After this fixing, compiler/runtime/TestConstantsInError.java passed without failure.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8290164: compiler/runtime/TestConstantsInError.java fails on riscv

Reviewers

• Fei Yang (@RealFYang - Reviewer)
• Yadong Wang (@yadongw - Author)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9463/head:pull/9463
$ git checkout pull/9463

Update a local copy of the PR:
$ git checkout pull/9463
$ git pull https://git.openjdk.org/jdk pull/9463/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9463

View PR using the GUI difftool:
$ git pr show -t 9463

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9463.diff

[bridgekeeper]

👋 Welcome back fjiang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@feilongjiang The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (1acc00f1)

[RealFYang]

Looks good and reasonable.

[openjdk]

@feilongjiang This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8290164: compiler/runtime/TestConstantsInError.java fails on riscv

Reviewed-by: fyang, yadongwang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 27 new commits pushed to the master branch:

• dbab827: 8249834: java/util/ArrayList/Bug8146568.java and j/u/Vector/Bug8148174.java use @ignore w/o bug-id
• 3216d19: 8289559: java/awt/a11y/AccessibleJPopupMenuTest.java test fails with java.lang.NullPointerException
• c83fcbd: 8290079: Reduce interaction with volatile in static initializer of BigInteger
• 74ac5df: 8290234: [JVMCI] use JVMCIKlassHandle to protect raw Klass* values from concurrent G1 scanning
• 5e3ecff: 8290253: gc/g1/TestVerificationInConcurrentCycle.java#id1 fails with "Error. can't find sun.hotspot.WhiteBox in test directory or libraries"
• 5358045: 8066859: java/lang/ref/OOMEInReferenceHandler.java failed with java.lang.Exception: Reference Handler thread died
• 2583feb: 8290023: Remove use of IgnoreUnrecognizedVMOptions in gc tests
• 44fb92e: 8290197: test/jdk/java/nio/file/Files/probeContentType/Basic.java fails on some systems for the ".rar" extension
• f528124: 8289284: jdk.tracePinnedThreads output confusing when pinned due to native frame
• 572c14e: 8288624: Cleanup CommentHelper.getText0
• ... and 17 more: https://git.openjdk.org/jdk/compare/f42dab85924d6a74d1c2c87bca1970e2362f45ea...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealFYang) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[feilongjiang]

@RealFYang -- thanks for the review! Integrate then.
/integrate

[openjdk]

@feilongjiang
Your change (at version 1acc00f) is now ready to be sponsored by a Committer.

[yadongw]

lgtm

[DamonFool]

/sponsor

[openjdk]

Going to push as commit 3471ac9.
Since your change was applied there have been 27 commits pushed to the master branch:

• dbab827: 8249834: java/util/ArrayList/Bug8146568.java and j/u/Vector/Bug8148174.java use @ignore w/o bug-id
• 3216d19: 8289559: java/awt/a11y/AccessibleJPopupMenuTest.java test fails with java.lang.NullPointerException
• c83fcbd: 8290079: Reduce interaction with volatile in static initializer of BigInteger
• 74ac5df: 8290234: [JVMCI] use JVMCIKlassHandle to protect raw Klass* values from concurrent G1 scanning
• 5e3ecff: 8290253: gc/g1/TestVerificationInConcurrentCycle.java#id1 fails with "Error. can't find sun.hotspot.WhiteBox in test directory or libraries"
• 5358045: 8066859: java/lang/ref/OOMEInReferenceHandler.java failed with java.lang.Exception: Reference Handler thread died
• 2583feb: 8290023: Remove use of IgnoreUnrecognizedVMOptions in gc tests
• 44fb92e: 8290197: test/jdk/java/nio/file/Files/probeContentType/Basic.java fails on some systems for the ".rar" extension
• f528124: 8289284: jdk.tracePinnedThreads output confusing when pinned due to native frame
• 572c14e: 8288624: Cleanup CommentHelper.getText0
• ... and 17 more: https://git.openjdk.org/jdk/compare/f42dab85924d6a74d1c2c87bca1970e2362f45ea...master

Your commit was automatically rebased without conflicts.

[openjdk]

@DamonFool @feilongjiang Pushed as commit 3471ac9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.