8290178: failure_handler: run netstat without name lookups

[djelinski]

netstat -av in Mac OS X failure handler is frequently running into the 20 second timeout, leaving us with no socket information. This PR proposes running netstat -anv along with the existing netstat -av, so that we have at least some socket information if the original command times out.

netstat -anv does not perform reverse DNS lookups on the socket IP addresses. The output contains IP addresses instead of DNS names. The command usually finishes in a few milliseconds.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8290178: failure_handler: run netstat without name lookups

Reviewers

• Jaikiran Pai (@jaikiran - Reviewer)
• Daniel Fuchs (@dfuch - Reviewer)
• Mark Sheppard (@msheppar - Reviewer)
• Leonid Mesnik (@lmesnik - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9469/head:pull/9469
$ git checkout pull/9469

Update a local copy of the PR:
$ git checkout pull/9469
$ git pull https://git.openjdk.org/jdk pull/9469/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9469

View PR using the GUI difftool:
$ git pr show -t 9469

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9469.diff

[bridgekeeper]

👋 Welcome back djelinski! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@djelinski The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (67caeca5)

[jaikiran]

Looks fine to me.

@lmesnik, could you also please take a look at this change?

[openjdk]

@djelinski This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8290178: failure_handler: run netstat without name lookups

Reviewed-by: jpai, dfuchs, msheppar, lmesnik

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 24 new commits pushed to the master branch:

• 3216d19: 8289559: java/awt/a11y/AccessibleJPopupMenuTest.java test fails with java.lang.NullPointerException
• c83fcbd: 8290079: Reduce interaction with volatile in static initializer of BigInteger
• 74ac5df: 8290234: [JVMCI] use JVMCIKlassHandle to protect raw Klass* values from concurrent G1 scanning
• 5e3ecff: 8290253: gc/g1/TestVerificationInConcurrentCycle.java#id1 fails with "Error. can't find sun.hotspot.WhiteBox in test directory or libraries"
• 5358045: 8066859: java/lang/ref/OOMEInReferenceHandler.java failed with java.lang.Exception: Reference Handler thread died
• 2583feb: 8290023: Remove use of IgnoreUnrecognizedVMOptions in gc tests
• 44fb92e: 8290197: test/jdk/java/nio/file/Files/probeContentType/Basic.java fails on some systems for the ".rar" extension
• f528124: 8289284: jdk.tracePinnedThreads output confusing when pinned due to native frame
• 572c14e: 8288624: Cleanup CommentHelper.getText0
• 6e18883: 8290162: Reset recursion counter missed in fix of JDK-8224267
• ... and 14 more: https://git.openjdk.org/jdk/compare/04c47da118b2870d1c7525348a2ffdf9cd1cc0a4...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[djelinski]

/integrate

[openjdk]

Going to push as commit 292d909.
Since your change was applied there have been 36 commits pushed to the master branch:

• a7f8358: Merge
• ce36f6e: 8290203: ProblemList vmTestbase/nsk/jvmti/scenarios/capability/CM03/cm03t001/TestDescription.java on linux-all
• fff7f35: 8290201: ProblemList com/sun/jdi/InvokeHangTest.java on macosx-x64 in vthread mode
• 128c6c6: 8290095: java/nio/channels/FileChannel/largeMemory/LargeGatheringWrite.java timed out
• 59d0c73: 8289930: Improve Thread description of inherited AccessControlContext
• 4545ed6: 8289365: SegmentAllocator:allocateArray(MemoryLayout, count) does not throw IAEx when count is -1
• 0fd1b68: 8290071: Javadoc for MemorySegment/MemoryAddress getter/setters contains some typos
• 2baf526: 8288850: SegmentAllocator:allocate() can return null some cases
• 02fae60: 8288067: Avoid redundant HashMap.containsKey call in Type1Font.expandAbbreviation
• 5d588ed: 8290218: AIX build failure by JDK-8289780
• ... and 26 more: https://git.openjdk.org/jdk/compare/04c47da118b2870d1c7525348a2ffdf9cd1cc0a4...master

Your commit was automatically rebased without conflicts.

[openjdk]

@djelinski Pushed as commit 292d909.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.