8290180: Convert com/sun/management/UnixOperatingSystemMXBean/GetOpenFileDescriptorCount.sh to jtreg java version #9503

bwhuang-us · 2022-07-14T21:56:57Z

This is a task to convert shell tests to Java tests. The shell scripts to be removed are responsible for compiling Java files and running the tests on Linux systems. This functionality can be achieved with JTReg tag @requires (os.family=="linux").

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issues

JDK-8290180: Convert com/sun/management/UnixOperatingSystemMXBean/GetOpenFileDescriptorCount.sh to jtreg java version
JDK-8290181: convert com/sun/management/UnixOperatingSystemMXBean/GetMaxFileDescriptorCount.sh to java version

Reviewers

Leonid Mesnik (@lmesnik - Reviewer)
Alex Menkov (@alexmenkov - Reviewer) ⚠️ Review applies to 13d99c69

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9503/head:pull/9503
$ git checkout pull/9503

Update a local copy of the PR:
$ git checkout pull/9503
$ git pull https://git.openjdk.org/jdk pull/9503/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9503

View PR using the GUI difftool:
$ git pr show -t 9503

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9503.diff

bridgekeeper · 2022-07-14T21:57:33Z

👋 Welcome back bwhuang-us! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bwhuang-us · 2022-07-14T21:57:59Z

/issue JDK-8290180

bwhuang-us · 2022-07-14T21:58:08Z

/issue add JDK-8290181

openjdk · 2022-07-14T22:01:30Z

@bwhuang-us This issue is referenced in the PR title - it will now be updated.

openjdk · 2022-07-14T22:01:49Z

@bwhuang-us
Adding additional issue to issue list: 8290181: convert com/sun/management/UnixOperatingSystemMXBean/GetMaxFileDescriptorCount.sh to java version.

openjdk · 2022-07-14T22:05:40Z

@bwhuang-us The following labels will be automatically applied to this pull request:

jmx
serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

mlbridge · 2022-07-14T22:09:43Z

Webrevs

lmesnik · 2022-07-14T22:20:23Z

test/jdk/com/sun/management/UnixOperatingSystemMXBean/GetMaxFileDescriptorCount.java

 * @bug     4858522
 * @summary Basic unit test of UnixOperatingSystemMXBean.getMaxFileDescriptorCount()
 * @author  Steve Bohne
+ * @requires (os.family=="linux")


please add spaces, braces are not required, see examples in jtreg tests
@requires os.family == "linux"

lmesnik · 2022-07-14T22:21:56Z

test/jdk/com/sun/management/UnixOperatingSystemMXBean/GetMaxFileDescriptorCount.java

 * @bug     4858522
 * @summary Basic unit test of UnixOperatingSystemMXBean.getMaxFileDescriptorCount()
 * @author  Steve Bohne
+ * @requires (os.family=="linux")
+ *
+ * @run main/othervm GetMaxFileDescriptorCount


is othervm required here?

No, it is not needed. I will remove it.

openjdk · 2022-07-14T22:46:36Z

@bwhuang-us This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8290180: Convert com/sun/management/UnixOperatingSystemMXBean/GetOpenFileDescriptorCount.sh to jtreg java version
8290181: convert com/sun/management/UnixOperatingSystemMXBean/GetMaxFileDescriptorCount.sh to java version

Reviewed-by: lmesnik, amenkov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 45 new commits pushed to the master branch:

ea8b75c: 8290334: Update FreeType to 2.12.1
6882f0e: 8290013: serviceability/jvmti/GetLocalVariable/GetLocalWithoutSuspendTest.java failed "assert(!in_vm) failed: Undersized StackShadowPages"
92067e2: 8290137: riscv: small refactoring for add_memory_int32/64
87340fd: 8288883: C2: assert(allow_address || t != T_ADDRESS) failed after JDK-8283091
bc7a1ea: 8288948: Few J2DBench tests indicate lower primitive drawing performance with metal rendering pipeline
84f2314: 8286030: Avoid JVM crash when containers share the same /tmp dir
4dd236b: 8290280: riscv: Clean up stack and register handling in interpreter
522b657: Merge
15d3329: 8281969: Bad result for the snippet @link tag if substring/regex consists of whitespace
c8e0315: 8290250: Shenandoah: disable Loom for iu mode
... and 35 more: https://git.openjdk.org/jdk/compare/c83fcbd18fff4d10c4162c43ddcdf3a51ce2c8e6...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@lmesnik, @alexmenkov) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

lmesnik · 2022-07-14T22:48:57Z

There are some possible cleanups in the tests (comments, unused args, variable name style) but seem out of scope for this PR.

bwhuang-us · 2022-07-14T22:54:51Z

It is not out of scope. I can do the clean up along with this PR. Can you please give me some hints what could be optimized?

lmesnik · 2022-07-14T23:01:50Z

The variables should use camelCase. Like min_count_for_pass -> minCountForPass
Variable trace not needed, just print count always
The mention of Solaris should be removed from comments, also I don't know if instructions for manual testing are needed, but it would be better to say "to know actual value run smth".

dholmes-ora · 2022-07-15T01:56:39Z

Is the restriction to run on Linux actually still valid? Shouldn't this work on any of our Posix-like platforms? I suspect you need to read "Linux" as "not Solaris or Windows" when looking at this test (and possibly others).

bwhuang-us · 2022-07-15T16:46:43Z

@dholmes-ora I agreed. These tests should be working on any unix-based system. I can change the restriction to be not Windows. The other question is should we include Solaris as it is also unix based.

bwhuang-us · 2022-07-15T17:59:33Z

@lmesnik I've completely removed the comments for manual tests because I don't think manual tests are necessary in this scenario. If the purpose of the manual tests is to compare FD count from the Java API to the system properties, it can be done in automated ways. Potential test cases could be opening a new file and observing increment to the opened FD count, or checking the value from the system call, etc. We can address this in a separate ticket if we want.

alexmenkov · 2022-07-15T21:36:24Z

Still good to me

dholmes-ora · 2022-07-18T02:02:17Z

The other question is should we include Solaris as it is also unix based.

@bwhuang-us there is no Solaris support in mainline.

bwhuang-us · 2022-07-18T16:36:58Z

/integrate

openjdk · 2022-07-18T16:38:57Z

@bwhuang-us
Your change (at version fed0b27) is now ready to be sponsored by a Committer.

lmesnik · 2022-08-08T15:05:05Z

/sponsor

openjdk · 2022-08-08T15:06:59Z

Going to push as commit 124fc4a.
Since your change was applied there have been 294 commits pushed to the master branch:

4591937: 8290357: Drop HeapRegion::marked_bytes()
7676be8: 8291037: Move PLAB resizing mechanism to G1EvacStats
861cc67: 8291897: TerminatingThreadLocal(s) not registered from virtual thread(s)
8d88be2: 8291459: JVM crash with GenerateOopMap::error_work(char const*, __va_list_tag*)
8a804f6: 8291454: Missing check for JLI C runtime library in CoreLibraries.gmk
5a539e8: 8291893: riscv: remove fence.i used in user space
b2f0cbd: 8064787: [macosx] In Nimbus LaF, Ctrl+Alt mnemonic doesn't work
891df21: 8259687: JTabbedPane.setComponentAt doesn't hide previously visible tab component
d4fb91b: 8291956: Simplify the loop condition in sun.net.httpserver.Request constructor
20123ea: 8291901: IGV: Preference menu disappears after JDK-8288750
... and 284 more: https://git.openjdk.org/jdk/compare/c83fcbd18fff4d10c4162c43ddcdf3a51ce2c8e6...master

Your commit was automatically rebased without conflicts.

openjdk · 2022-08-08T15:07:19Z

@lmesnik @bwhuang-us Pushed as commit 124fc4a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

bwhuang-us added 2 commits July 13, 2022 18:10

Converted FileDescriptorCount shell tests to java tests.

8ee88c3

Updated copyright header.

69ed7ea

openjdk bot added the rfr Pull request is ready for review label Jul 14, 2022

openjdk bot added serviceability serviceability-dev@openjdk.org jmx jmx-dev@openjdk.org labels Jul 14, 2022

lmesnik reviewed Jul 14, 2022

View reviewed changes

Removed othervm option and fixed @requires coding style.

13d99c6

lmesnik approved these changes Jul 14, 2022

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Jul 14, 2022

alexmenkov approved these changes Jul 14, 2022

View reviewed changes

Cleaned up tests and changed OS restriction to not windows.

76c46d0

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 15, 2022

Removed unwanted whitespaces.

fed0b27

openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 15, 2022

lmesnik approved these changes Jul 15, 2022

View reviewed changes

openjdk bot added the sponsor Pull request is ready to be sponsored label Jul 18, 2022

openjdk bot added the integrated Pull request has been integrated label Aug 8, 2022

openjdk bot closed this Aug 8, 2022

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Aug 8, 2022

bwhuang-us deleted the JDK-8290180 branch March 1, 2023 18:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8290180: Convert com/sun/management/UnixOperatingSystemMXBean/GetOpenFileDescriptorCount.sh to jtreg java version #9503

8290180: Convert com/sun/management/UnixOperatingSystemMXBean/GetOpenFileDescriptorCount.sh to jtreg java version #9503

bwhuang-us commented Jul 14, 2022 •

edited by openjdk bot

bridgekeeper bot commented Jul 14, 2022

bwhuang-us commented Jul 14, 2022

bwhuang-us commented Jul 14, 2022

openjdk bot commented Jul 14, 2022

openjdk bot commented Jul 14, 2022

openjdk bot commented Jul 14, 2022

mlbridge bot commented Jul 14, 2022 •

edited

lmesnik Jul 14, 2022

lmesnik Jul 14, 2022

bwhuang-us Jul 14, 2022

openjdk bot commented Jul 14, 2022 •

edited

lmesnik commented Jul 14, 2022

bwhuang-us commented Jul 14, 2022

lmesnik commented Jul 14, 2022

dholmes-ora commented Jul 15, 2022

bwhuang-us commented Jul 15, 2022

bwhuang-us commented Jul 15, 2022 •

edited

alexmenkov commented Jul 15, 2022

dholmes-ora commented Jul 18, 2022

bwhuang-us commented Jul 18, 2022

openjdk bot commented Jul 18, 2022

lmesnik commented Aug 8, 2022

openjdk bot commented Aug 8, 2022

openjdk bot commented Aug 8, 2022

8290180: Convert com/sun/management/UnixOperatingSystemMXBean/GetOpenFileDescriptorCount.sh to jtreg java version #9503

8290180: Convert com/sun/management/UnixOperatingSystemMXBean/GetOpenFileDescriptorCount.sh to jtreg java version #9503

Conversation

bwhuang-us commented Jul 14, 2022 • edited by openjdk bot

Progress

Issues

Reviewers

Reviewing

bridgekeeper bot commented Jul 14, 2022

bwhuang-us commented Jul 14, 2022

bwhuang-us commented Jul 14, 2022

openjdk bot commented Jul 14, 2022

openjdk bot commented Jul 14, 2022

openjdk bot commented Jul 14, 2022

mlbridge bot commented Jul 14, 2022 • edited

Webrevs

lmesnik Jul 14, 2022

Choose a reason for hiding this comment

lmesnik Jul 14, 2022

Choose a reason for hiding this comment

bwhuang-us Jul 14, 2022

Choose a reason for hiding this comment

openjdk bot commented Jul 14, 2022 • edited

lmesnik commented Jul 14, 2022

bwhuang-us commented Jul 14, 2022

lmesnik commented Jul 14, 2022

dholmes-ora commented Jul 15, 2022

bwhuang-us commented Jul 15, 2022

bwhuang-us commented Jul 15, 2022 • edited

alexmenkov commented Jul 15, 2022

dholmes-ora commented Jul 18, 2022

bwhuang-us commented Jul 18, 2022

openjdk bot commented Jul 18, 2022

lmesnik commented Aug 8, 2022

openjdk bot commented Aug 8, 2022

openjdk bot commented Aug 8, 2022

bwhuang-us commented Jul 14, 2022 •

edited by openjdk bot

mlbridge bot commented Jul 14, 2022 •

edited

openjdk bot commented Jul 14, 2022 •

edited

bwhuang-us commented Jul 15, 2022 •

edited