8289801: [IR Framework] Add flags to whitelist which can be used to simulate a specific machine setup like UseAVX

[DamonFool]

Hi all,

Please review this trivial change which adds UseAVX, UseSSE and UseSVE to the whitelist of IR test framework.

Thanks.
Best regards,
Jie

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8289801: [IR Framework] Add flags to whitelist which can be used to simulate a specific machine setup like UseAVX

Reviewers

• Vladimir Kozlov (@vnkozlov - Reviewer)
• Xiaohong Gong (@XiaohongGong - Committer)
• Tobias Hartmann (@TobiHartmann - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9509/head:pull/9509
$ git checkout pull/9509

Update a local copy of the PR:
$ git checkout pull/9509
$ git pull https://git.openjdk.org/jdk pull/9509/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9509

View PR using the GUI difftool:
$ git pr show -t 9509

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9509.diff

[bridgekeeper]

👋 Welcome back jiefu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@DamonFool The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (823699a5)
• 00: Full (00efdca7)

[vnkozlov]

Consider adding IR tests to vector testing group which we (Oracle) run with different AVX,SSE settings:

test/hotspot/jtreg/TEST.groups
@@ -84,6 +84,7 @@ hotspot_containers_extended = \
 
 hotspot_vector_1 = \
   compiler/c2/cr6340864 \
+  compiler/c2/irTests \
   compiler/codegen \
   compiler/loopopts/superword \
   compiler/vectorapi \

I submitted testing with this additional change.

[vnkozlov]

compiler/c2/irTests/TestVectorizeURShiftSubword.java test failed. Details in RFE.

[DamonFool]

Consider adding IR tests to vector testing group which we (Oracle) run with different AVX,SSE settings:

IR tests had been added into vector testing.

[DamonFool]

compiler/c2/irTests/TestVectorizeURShiftSubword.java test failed. Details in RFE.

Thanks @vnkozlov for the review and testing.

I can only reproduce the failure with UseSSE < 4, but passed with UseAVX=0 on x86.
The reason is that RShiftVB isn't supported with UseSSE < 4 on x86.
The fix just skips the test when UseSSE < 4 on x86.
Thanks.

[XiaohongGong]

Looks good to me! Thanks!

[TobiHartmann]

Looks good to me. I'll run testing and report back once it passed.

[openjdk]

@DamonFool This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8289801: [IR Framework] Add flags to whitelist which can be used to simulate a specific machine setup like UseAVX

Reviewed-by: kvn, xgong, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 18 new commits pushed to the master branch:

• ea8b75c: 8290334: Update FreeType to 2.12.1
• 6882f0e: 8290013: serviceability/jvmti/GetLocalVariable/GetLocalWithoutSuspendTest.java failed "assert(!in_vm) failed: Undersized StackShadowPages"
• 92067e2: 8290137: riscv: small refactoring for add_memory_int32/64
• 87340fd: 8288883: C2: assert(allow_address || t != T_ADDRESS) failed after JDK-8283091
• bc7a1ea: 8288948: Few J2DBench tests indicate lower primitive drawing performance with metal rendering pipeline
• 84f2314: 8286030: Avoid JVM crash when containers share the same /tmp dir
• 4dd236b: 8290280: riscv: Clean up stack and register handling in interpreter
• 522b657: Merge
• 15d3329: 8281969: Bad result for the snippet @link tag if substring/regex consists of whitespace
• c8e0315: 8290250: Shenandoah: disable Loom for iu mode
• ... and 8 more: https://git.openjdk.org/jdk/compare/92deab546549ca549408a983fe361d9536d2cd37...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[TobiHartmann]

All tests passed.

[vnkozlov]

Good.

[DamonFool]

Thank you all for the review and testing.
/integrate

[openjdk]

Going to push as commit 4a4d8ed.
Since your change was applied there have been 26 commits pushed to the master branch:

• 5a96a5d: 8289612: Change hotspot/jtreg tests to not use Thread.stop
• b65f7ec: 4887998: Use Integer.rotateLeft() and rotateRight() in crypto implementations
• 6c8d0e6: 8282526: Default icon is not painted properly
• e72742e: 8286172: Create an automated test for JDK-4516019
• b9de0a7: 8284524: Create an automated test for JDK-4422362
• 5ae4320: 8284767: Create an automated test for JDK-4422535
• efed7a7: 8289908: Skip bounds check for cases when String is constructed from entirely used byte[]
• b2010a7: 8287805: Shenandoah: consolidate evacuate-update-root closures
• ea8b75c: 8290334: Update FreeType to 2.12.1
• 6882f0e: 8290013: serviceability/jvmti/GetLocalVariable/GetLocalWithoutSuspendTest.java failed "assert(!in_vm) failed: Undersized StackShadowPages"
• ... and 16 more: https://git.openjdk.org/jdk/compare/92deab546549ca549408a983fe361d9536d2cd37...master

Your commit was automatically rebased without conflicts.

[openjdk]

@DamonFool Pushed as commit 4a4d8ed.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.