8290379: Parse error with parenthesized pattern and guard using an array

[biboudis]

Addresses the parsing error for the following case:

case (String s) when (arr[0] == 1) -> 0;

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8290379: Parse error with parenthesized pattern and guard using an array

Reviewers

• Jan Lahoda (@lahodaj - Reviewer) ⚠️ Review applies to 32cd4677

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9519/head:pull/9519
$ git checkout pull/9519

Update a local copy of the PR:
$ git checkout pull/9519
$ git pull https://git.openjdk.org/jdk pull/9519/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9519

View PR using the GUI difftool:
$ git pr show -t 9519

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9519.diff

[bridgekeeper]

👋 Welcome back abimpoudis! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@biboudis The following label will be automatically applied to this pull request:

• compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (0fb22ebe)
• 00: Full (32cd4677)

[lahodaj]

Seems reasonable, but the code may possibly be simpler.

[openjdk]

@biboudis This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8290379: Parse error with parenthesized pattern and guard using an array

Reviewed-by: jlahoda

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

• 6882f0e: 8290013: serviceability/jvmti/GetLocalVariable/GetLocalWithoutSuspendTest.java failed "assert(!in_vm) failed: Undersized StackShadowPages"
• 92067e2: 8290137: riscv: small refactoring for add_memory_int32/64
• 87340fd: 8288883: C2: assert(allow_address || t != T_ADDRESS) failed after JDK-8283091
• bc7a1ea: 8288948: Few J2DBench tests indicate lower primitive drawing performance with metal rendering pipeline
• 84f2314: 8286030: Avoid JVM crash when containers share the same /tmp dir
• 4dd236b: 8290280: riscv: Clean up stack and register handling in interpreter
• 522b657: Merge
• 15d3329: 8281969: Bad result for the snippet @link tag if substring/regex consists of whitespace
• c8e0315: 8290250: Shenandoah: disable Loom for iu mode
• fb27ddc: 8290252: Add TEST.properties to java/nio/channels/FileChannel and move tests out of largeMemory sub-dir
• ... and 5 more: https://git.openjdk.org/jdk/compare/b4e2ce0094751540ac0673b22af3b3221d1fd74a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@lahodaj) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[biboudis]

/integrate

[openjdk]

@biboudis
Your change (at version 0fb22eb) is now ready to be sponsored by a Committer.

[openjdk-notifier]

@biboudis Please do not rebase or force-push to an active PR as it invalidates existing review comments. All changes will be squashed into a single commit automatically when integrating. See OpenJDK Developers’ Guide for more information.

[lahodaj]

/sponsor

[openjdk]

Going to push as commit f5a7de8.
Since your change was applied there have been 33 commits pushed to the master branch:

• 612d8c6: 8290456: remove os::print_statistics()
• d7f0de2: 8290460: Alpine: disable some panama tests that rely on std::thread
• dfbc691: 8289524: Add JFR JIT restart event
• 4e6cd67: 8290000: Bump macOS GitHub actions to macOS 11
• af86cd3: 8290463: Fix several comment typos in sun.security.ec
• 6cd1c0c: Merge
• 2677dd6: 8289954: C2: Assert failed in PhaseCFG::verify() after JDK-8183390
• 4f3f74c: 8289127: Apache Lucene triggers: DEBUG MESSAGE: duplicated predicate failed which is impossible
• 4a4d8ed: 8289801: [IR Framework] Add flags to whitelist which can be used to simulate a specific machine setup like UseAVX
• 5a96a5d: 8289612: Change hotspot/jtreg tests to not use Thread.stop
• ... and 23 more: https://git.openjdk.org/jdk/compare/b4e2ce0094751540ac0673b22af3b3221d1fd74a...master

Your commit was automatically rebased without conflicts.

[openjdk]

@lahodaj @biboudis Pushed as commit f5a7de8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.