8290391: Reduce runtime of java.util package microbenchmarks #9523

ericcaspole · 2022-07-15T18:41:09Z

Adds Warmup, Measurement and Fork annotations to reduce the run time from 1 day 16 hours to 8 hours for this set.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8290391: Reduce runtime of java.util package microbenchmarks

Reviewers

Roger Riggs (@RogerRiggs - Reviewer) ⚠️ Review applies to 8d71eb4e
Claes Redestad (@cl4es - Reviewer) ⚠️ Review applies to 8d71eb4e

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9523/head:pull/9523
$ git checkout pull/9523

Update a local copy of the PR:
$ git checkout pull/9523
$ git pull https://git.openjdk.org/jdk pull/9523/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9523

View PR using the GUI difftool:
$ git pr show -t 9523

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9523.diff

bridgekeeper · 2022-07-15T18:42:19Z

👋 Welcome back ecaspole! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2022-07-15T18:44:39Z

@ericcaspole The following label will be automatically applied to this pull request:

core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2022-07-15T18:48:28Z

Webrevs

01: Full - Incremental (50028d59)
00: Full (8d71eb4e)

RogerRiggs

LGTM

openjdk · 2022-07-18T14:53:23Z

@ericcaspole This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8290391: Reduce runtime of java.util package microbenchmarks

Reviewed-by: rriggs, redestad

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 23 new commits pushed to the master branch:

b2010a7: 8287805: Shenandoah: consolidate evacuate-update-root closures
ea8b75c: 8290334: Update FreeType to 2.12.1
6882f0e: 8290013: serviceability/jvmti/GetLocalVariable/GetLocalWithoutSuspendTest.java failed "assert(!in_vm) failed: Undersized StackShadowPages"
92067e2: 8290137: riscv: small refactoring for add_memory_int32/64
87340fd: 8288883: C2: assert(allow_address || t != T_ADDRESS) failed after JDK-8283091
bc7a1ea: 8288948: Few J2DBench tests indicate lower primitive drawing performance with metal rendering pipeline
84f2314: 8286030: Avoid JVM crash when containers share the same /tmp dir
4dd236b: 8290280: riscv: Clean up stack and register handling in interpreter
522b657: Merge
15d3329: 8281969: Bad result for the snippet @link tag if substring/regex consists of whitespace
... and 13 more: https://git.openjdk.org/jdk/compare/3ad39505605f8eab74adec9c68f211dd44796759...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

cl4es

LGTM, some suggestions inline that you can choose to ignore

cl4es · 2022-07-18T15:00:41Z

test/micro/org/openjdk/bench/java/util/ArraysFill.java

@@ -39,6 +40,9 @@
 @BenchmarkMode(Mode.Throughput)
 @OutputTimeUnit(TimeUnit.MILLISECONDS)
 @State(Scope.Thread)
+@Warmup(iterations = 4, time = 2)
+@Measurement(iterations = 4, time = 2)
+@Fork(value = 3)
 public class ArraysFill {

    @Param({"10", "16", "31", "59", "89", "126", "250", "266", "511", "1021", "2047", "2048", "4095", "8195"})


Can we prune a few of these?

cl4es · 2022-07-18T15:02:20Z

test/micro/org/openjdk/bench/java/util/ArraysMismatchPartialInlining.java

@@ -38,6 +39,9 @@
 @BenchmarkMode(Mode.Throughput)
 @OutputTimeUnit(TimeUnit.MILLISECONDS)
 @State(Scope.Thread)
+@Warmup(iterations = 4, time = 2)
+@Measurement(iterations = 4, time = 2)
+@Fork(value = 3)
 public class ArraysMismatchPartialInlining {

    @Param({"3", "4", "5", "6", "7", "15", "31", "63", "95", "800"})


Can we prune a few of these? At least 4, 5, 6 seem like they'll not add much signal.

cl4es · 2022-07-18T15:03:53Z

test/micro/org/openjdk/bench/java/util/Base64VarLenDecode.java

@@ -85,6 +84,9 @@ public void doTearDownInvocation() {
    }

    @Benchmark
+    @Warmup(iterations = 4, time = 2)


I prefer putting these at class level (even when there's only one @Benchmark)

ericcaspole · 2022-07-18T17:21:20Z

I applied Claes comments in the last push.

ericcaspole · 2022-07-19T16:29:38Z

/integrate

openjdk · 2022-07-19T16:30:51Z

Going to push as commit 2cb659e.
Since your change was applied there have been 44 commits pushed to the master branch:

bbc5748: 8272096: Exceptions::new_exception can return wrong exception
a41b12f: 8290512: G1: Fix typo in allocation statistics log message
e02627c: 8290397: LoadLibraryUnload.java failed with "Too few cleared WeakReferences"
2ff2208: 8289804: Remove redundant stream() call before forEach in jdk.jshell
f5a7de8: 8290379: Parse error with parenthesized pattern and guard using an array
612d8c6: 8290456: remove os::print_statistics()
d7f0de2: 8290460: Alpine: disable some panama tests that rely on std::thread
dfbc691: 8289524: Add JFR JIT restart event
4e6cd67: 8290000: Bump macOS GitHub actions to macOS 11
af86cd3: 8290463: Fix several comment typos in sun.security.ec
... and 34 more: https://git.openjdk.org/jdk/compare/3ad39505605f8eab74adec9c68f211dd44796759...master

Your commit was automatically rebased without conflicts.

openjdk · 2022-07-19T16:31:11Z

@ericcaspole Pushed as commit 2cb659e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

8290391: Reduce runtime of java.util package microbenchmarks

8d71eb4

openjdk bot added the rfr Pull request is ready for review label Jul 15, 2022

openjdk bot added the core-libs core-libs-dev@openjdk.org label Jul 15, 2022

RogerRiggs approved these changes Jul 18, 2022

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Jul 18, 2022

cl4es approved these changes Jul 18, 2022

View reviewed changes

Apply @cl4es comments

50028d5

openjdk bot added the integrated Pull request has been integrated label Jul 19, 2022

openjdk bot closed this Jul 19, 2022

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 19, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8290391: Reduce runtime of java.util package microbenchmarks #9523

8290391: Reduce runtime of java.util package microbenchmarks #9523

ericcaspole commented Jul 15, 2022 •

edited by openjdk bot

bridgekeeper bot commented Jul 15, 2022

openjdk bot commented Jul 15, 2022

mlbridge bot commented Jul 15, 2022 •

edited

RogerRiggs left a comment

openjdk bot commented Jul 18, 2022 •

edited

cl4es left a comment

cl4es Jul 18, 2022

cl4es Jul 18, 2022

cl4es Jul 18, 2022

ericcaspole commented Jul 18, 2022

ericcaspole commented Jul 19, 2022

openjdk bot commented Jul 19, 2022

openjdk bot commented Jul 19, 2022

8290391: Reduce runtime of java.util package microbenchmarks #9523

8290391: Reduce runtime of java.util package microbenchmarks #9523

Conversation

ericcaspole commented Jul 15, 2022 • edited by openjdk bot

Progress

Issue

Reviewers

Reviewing

bridgekeeper bot commented Jul 15, 2022

openjdk bot commented Jul 15, 2022

mlbridge bot commented Jul 15, 2022 • edited

Webrevs

RogerRiggs left a comment

Choose a reason for hiding this comment

openjdk bot commented Jul 18, 2022 • edited

cl4es left a comment

Choose a reason for hiding this comment

cl4es Jul 18, 2022

Choose a reason for hiding this comment

cl4es Jul 18, 2022

Choose a reason for hiding this comment

cl4es Jul 18, 2022

Choose a reason for hiding this comment

ericcaspole commented Jul 18, 2022

ericcaspole commented Jul 19, 2022

openjdk bot commented Jul 19, 2022

openjdk bot commented Jul 19, 2022

ericcaspole commented Jul 15, 2022 •

edited by openjdk bot

mlbridge bot commented Jul 15, 2022 •

edited

openjdk bot commented Jul 18, 2022 •

edited