8290471: jpackage: allow to specify codepage on Windows

[akashche]

It is proposed to introduce support for --win-codepage argument, and substitute the Codepage attribute with --win-codepage specified value in primary l10n file when it is being copied to the config dir.

Instead of copying all internal l10n files, it is proposed to copy only the primary file. Plain copy is used if --win-codepage is not specified. Otherwise --win-codepage value is substituted in l10n file using DOM and XPath.

See more details in issue description and in links added there.

Testing:

• ran jtreg:jdk/tools/jpackage
• test for --win-codepage argument is included with the patch

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change requires a CSR request to be approved

Issues

• JDK-8290471: jpackage: allow to specify codepage on Windows
• JDK-8290519: jpackage: allow to specify codepage on Windows (CSR)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9546/head:pull/9546
$ git checkout pull/9546

Update a local copy of the PR:
$ git checkout pull/9546
$ git pull https://git.openjdk.org/jdk pull/9546/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9546

View PR using the GUI difftool:
$ git pr show -t 9546

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9546.diff

[bridgekeeper]

👋 Welcome back akasko! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@akashche The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (0e4241ce)
• 00: Full (aefec1ce)

[alexeysemenyukoracle]

This is a proposal to change public API. It requires CSR.
One of jpackage CSRs - https://bugs.openjdk.org/browse/JDK-8261538. You can use it as a reference.
CSR wiki - https://wiki.openjdk.org/display/csr

[akashche]

Thanks for the example link! I've filed CSR based on it - JDK-8290519.

[akashche]

I've extended the test covering multiple languages with UTF-8. Also added new flag description to --help output.

[bridgekeeper]

@akashche This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper]

@akashche This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.