Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8290496: riscv: Fix build warnings-as-errors with GCC 11 #9550

Closed
wants to merge 1 commit into from

Conversation

RealFYang
Copy link
Member

@RealFYang RealFYang commented Jul 19, 2022

Like AArch64 port, RISC-V port defines DEOPTIMIZE_WHEN_PATCHING and does not make use of C1 runtime patching.
Then there is no need to implement class NativeMovRegMem in the port-specific code. But that will make GCC 11 unhappy.

One way would be guarding the C1 shared code like class PatchingStub which uses class NativeMovRegMem under condition #ifndef DEOPTIMIZE_WHEN_PATCHING. But turns out class PatchingStub are still partially used (mainly the PatchID enum) even under DEOPTIMIZE_WHEN_PATCHING.

So PR takes another way fixing this warning by implementing the NativeMovRegMem class for RISC-V like Like AArch64 port.

Testing: release & fastdebug build OK without --disable-warnings-as-errors


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8290496: riscv: Fix build warnings-as-errors with GCC 11

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9550/head:pull/9550
$ git checkout pull/9550

Update a local copy of the PR:
$ git checkout pull/9550
$ git pull https://git.openjdk.org/jdk pull/9550/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9550

View PR using the GUI difftool:
$ git pr show -t 9550

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9550.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 19, 2022

👋 Welcome back fyang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 19, 2022
@openjdk
Copy link

openjdk bot commented Jul 19, 2022

@RealFYang The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Jul 19, 2022
@mlbridge
Copy link

mlbridge bot commented Jul 19, 2022

Webrevs

Copy link
Contributor

@yadongw yadongw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yadongw
Copy link
Contributor

yadongw commented Jul 19, 2022

Try GCC 12 if possible?

@RealFYang RealFYang closed this Jul 19, 2022
@RealFYang RealFYang reopened this Jul 19, 2022
@feilongjiang
Copy link
Member

Try GCC 12 if possible?

I have tried the native release build with GCC 12 (on Ubuntu 22.04, gcc version 12.0.1 20220319 (experimental)). The warning did not appear after this patch.

@RealFYang
Copy link
Member Author

@yadongw @feilongjiang : Thanks. Could we have a Reviewer please? @shipilev ?

Copy link
Member

@shipilev shipilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay!

@openjdk
Copy link

openjdk bot commented Jul 20, 2022

@RealFYang This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8290496: riscv: Fix build warnings-as-errors with GCC 11

Reviewed-by: yadongwang, fjiang, shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 32 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 20, 2022
@RealFYang
Copy link
Member Author

Looks okay!

Thanks all for the review.

/integrate

@openjdk
Copy link

openjdk bot commented Jul 20, 2022

Going to push as commit 5425573.
Since your change was applied there have been 32 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 20, 2022
@openjdk openjdk bot closed this Jul 20, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 20, 2022
@openjdk
Copy link

openjdk bot commented Jul 20, 2022

@RealFYang Pushed as commit 5425573.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@RealFYang RealFYang deleted the JDK-8290496 branch July 28, 2022 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
4 participants